Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1526553003: Revert of [debugger] debug-evaluate should not not modify local values. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@arrowthis
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ ) Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a2f2e913f89203c042b27f8fb0e6805056febb28 Cr-Commit-Position: refs/heads/master@{#32845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -95 lines) Patch
M src/debug/debug-evaluate.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/debug/debug-evaluate.cc View 7 chunks +9 lines, -23 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +2 lines, -6 lines 0 comments Download
M test/mjsunit/debug-evaluate-closure.js View 4 chunks +14 lines, -13 lines 0 comments Download
M test/mjsunit/debug-evaluate-const.js View 3 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals.js View 3 chunks +2 lines, -3 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals-capturing.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/debug-evaluate-modify-catch-block-scope.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/debug-evaluate-shadowed-context.js View 4 chunks +5 lines, -6 lines 0 comments Download
M test/mjsunit/es6/debug-blockscopes.js View 3 chunks +8 lines, -5 lines 0 comments Download
M test/mjsunit/regress-3225.js View 3 chunks +5 lines, -9 lines 0 comments Download
M test/mjsunit/regress/regress-325676.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-323936.js View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [debugger] debug-evaluate should not not modify local values.
5 years ago (2015-12-14 17:18:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1526553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1526553003/1
5 years ago (2015-12-14 17:18:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 17:19:12 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-14 17:19:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2f2e913f89203c042b27f8fb0e6805056febb28
Cr-Commit-Position: refs/heads/master@{#32845}

Powered by Google App Engine
This is Rietveld 408576698