src/flag-definitions.h - Issue 1526553003: Revert of [debugger] debug-evaluate should not not modify local values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1526553003: Revert of [debugger] debug-evaluate should not not modify local values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arrowthis

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index b42849e354a4cf655b8cbc2bdcae3f87cd4439c0..b98b9952613404e352565e01baefa06fdae0e446 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -597,7 +597,8 @@

DEFINE_INT(cpu_profiler_sampling_interval, 1000,

"CPU profiler sampling interval in microseconds")

-// Array abuse tracing

+// debug.cc

+DEFINE_BOOL(trace_debug_json, false, "trace debugging JSON request/response")

DEFINE_BOOL(trace_js_array_abuse, false,

"trace out-of-bounds accesses to JS arrays")

DEFINE_BOOL(trace_external_array_abuse, false,

@@ -606,11 +607,6 @@

"trace out-of-bounds accesses to all arrays")

DEFINE_IMPLICATION(trace_array_abuse, trace_js_array_abuse)

DEFINE_IMPLICATION(trace_array_abuse, trace_external_array_abuse)

-// debugger

-DEFINE_BOOL(debug_eval_readonly_locals, true,

- "do not update locals after debug-evaluate")

-DEFINE_BOOL(trace_debug_json, false, "trace debugging JSON request/response")

DEFINE_BOOL(enable_liveedit, true, "enable liveedit experimental feature")

DEFINE_BOOL(hard_abort, true, "abort by crashing")

« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | test/mjsunit/debug-evaluate-closure.js » ('j') | no next file with comments »