content/browser/frame_host/render_frame_host_impl.h - Issue 1526263003: Position autofill popup widgets correctly under --site-per-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/cross_process_frame_connector.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/renderer_host/render_widget_host_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index b457a076e55120811cd6f0c7b214af7d5c936e3a..48221a41c16077ee8f8c2ae680941f62af440ac2 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -168,6 +168,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

void InsertVisualStateCallback(

const VisualStateCallback& callback) override;

bool IsRenderFrameLive() override;

+ RenderWidgetHostView* GetView() override;

// IPC::Sender

bool Send(IPC::Message* msg) override;

@@ -247,9 +248,6 @@ class CONTENT_EXPORT RenderFrameHostImpl

// pointer to the RenderViewHost (which inherits RenderWidgetHost).

RenderWidgetHostImpl* GetRenderWidgetHost();

- // This returns the RenderWidgetHostView that can be used to control

- // focus and visibility for this frame.

- RenderWidgetHostView* GetView();

// This function is called when this is a swapped out RenderFrameHost that

// lives in the same process as the parent frame. The