content/browser/frame_host/render_frame_host_impl.cc - Issue 1526263003: Position autofill popup widgets correctly under --site-per-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | content/browser/renderer_host/render_widget_host_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index e57bde68e4829cdaf80a02109f7ab186fcc6b4f7..eda53dcb5ab51bb6e42c606dbc2ff5d3fc50fd10 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1327,9 +1327,9 @@ void RenderFrameHostImpl::OnContextMenu(const ContextMenuParams& params) {

// It is necessary to transform the coordinates to account for nested

// RenderWidgetHosts, such as with out-of-process iframes.

gfx::Point original_point(validated_params.x, validated_params.y);

- gfx::Point transformed_point = original_point;

- static_cast<RenderWidgetHostViewBase*>(GetView())

- ->TransformPointToRootCoordSpace(original_point, &transformed_point);

+ gfx::Point transformed_point =

+ static_cast<RenderWidgetHostViewBase*>(GetView())

+ ->TransformPointToRootCoordSpace(original_point);

validated_params.x = transformed_point.x();

validated_params.y = transformed_point.y();