Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mo IOS fixin Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index d714137a2d61d6ebabf9e083662286a8dbc43d75..a0ded9058622b3a09ba15b3acc1d3411151d77d8 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -88,6 +88,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
scoped_ptr<RenderWidgetHostViewFrameSubscriber> subscriber) override;
void EndFrameSubscription() override;
+ // This only needs to be overridden by RenderWidgetHostView subclasses
Charlie Reis 2016/01/21 00:33:03 Do you mean RenderWidgetHostViewBase subclasses?
kenrb 2016/01/22 18:33:58 Done.
+ // that handle content embedded within other RenderWidgetHostViews.
+ void TransformPointToRootCoordSpace(const gfx::Point& point,
+ gfx::Point* transformed_point) override;
+
// IPC::Listener implementation:
bool OnMessageReceived(const IPC::Message& msg) override;
@@ -204,15 +209,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
virtual void ProcessTouchEvent(const blink::WebTouchEvent& event,
const ui::LatencyInfo& latency) {}
- // If a RenderWidgetHost is dealing with points that are transformed from the
- // root frame for a page (i.e. because its content is contained within
- // that of another RenderWidgetHost), this provides a facility to convert
- // a point from its own coordinate space to that of the root frame.
- // This only needs to be overriden by RenderWidgetHostView subclasses
- // that handle content embedded within other RenderWidgetHostViews.
- virtual void TransformPointToRootCoordSpace(const gfx::Point& point,
- gfx::Point* transformed_point);
-
// Transform a point that is in the coordinate space of a Surface that is
// embedded within the RenderWidgetHostViewBase's Surface to the
// coordinate space of the embedding Surface. Typically this means that a

Powered by Google App Engine
This is Rietveld 408576698