content/browser/frame_host/render_frame_host_impl.h - Issue 1526263003: Position autofill popup widgets correctly under --site-per-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mo IOS fixin Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/test_autofill_driver.cc ('K') | « components/autofill/ios/browser/autofill_driver_ios.mm ('k') | content/browser/renderer_host/render_widget_host_view_base.h » ('j') | content/browser/renderer_host/render_widget_host_view_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index b457a076e55120811cd6f0c7b214af7d5c936e3a..c024006010305bbf4cd37c8a84c0109f524e7892 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -249,7 +249,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

// This returns the RenderWidgetHostView that can be used to control

// focus and visibility for this frame.

- RenderWidgetHostView* GetView();

+ RenderWidgetHostView* GetView() override;

Charlie Reis 2016/01/21 00:33:03 nit: This needs to move into the RenderViewHost ov

kenrb 2016/01/22 18:33:58 Done.

// This function is called when this is a swapped out RenderFrameHost that

// lives in the same process as the parent frame. The