Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1526263003: Position autofill popup widgets correctly under --site-per-process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mo IOS fixin Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 bool is_loading() const { return is_loading_; } 242 bool is_loading() const { return is_loading_; }
243 243
244 // This returns the RenderFrameHost's owned RenderWidgetHost if it has one, 244 // This returns the RenderFrameHost's owned RenderWidgetHost if it has one,
245 // or else it returns nullptr. 245 // or else it returns nullptr.
246 // If the RenderFrameHost is the page's main frame, this returns instead a 246 // If the RenderFrameHost is the page's main frame, this returns instead a
247 // pointer to the RenderViewHost (which inherits RenderWidgetHost). 247 // pointer to the RenderViewHost (which inherits RenderWidgetHost).
248 RenderWidgetHostImpl* GetRenderWidgetHost(); 248 RenderWidgetHostImpl* GetRenderWidgetHost();
249 249
250 // This returns the RenderWidgetHostView that can be used to control 250 // This returns the RenderWidgetHostView that can be used to control
251 // focus and visibility for this frame. 251 // focus and visibility for this frame.
252 RenderWidgetHostView* GetView(); 252 RenderWidgetHostView* GetView() override;
Charlie Reis 2016/01/21 00:33:03 nit: This needs to move into the RenderViewHost ov
kenrb 2016/01/22 18:33:58 Done.
253 253
254 // This function is called when this is a swapped out RenderFrameHost that 254 // This function is called when this is a swapped out RenderFrameHost that
255 // lives in the same process as the parent frame. The 255 // lives in the same process as the parent frame. The
256 // |cross_process_frame_connector| allows the non-swapped-out 256 // |cross_process_frame_connector| allows the non-swapped-out
257 // RenderFrameHost for a frame to communicate with the parent process 257 // RenderFrameHost for a frame to communicate with the parent process
258 // so that it may composite drawing data. 258 // so that it may composite drawing data.
259 // 259 //
260 // Ownership is not transfered. 260 // Ownership is not transfered.
261 void set_cross_process_frame_connector( 261 void set_cross_process_frame_connector(
262 CrossProcessFrameConnector* cross_process_frame_connector) { 262 CrossProcessFrameConnector* cross_process_frame_connector) {
(...skipping 627 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 890
891 // NOTE: This must be the last member. 891 // NOTE: This must be the last member.
892 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 892 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
893 893
894 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 894 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
895 }; 895 };
896 896
897 } // namespace content 897 } // namespace content
898 898
899 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 899 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698