Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152623002: Make StyleChange parameter explicit in setNeedsStyleRecalc. (Closed)

Created:
6 years, 10 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
ojan
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, fs, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney
Visibility:
Public.

Description

Make StyleChange parameter explicit in setNeedsStyleRecalc. The SubtreeStyleChange is a very expensive change, yet the default parameter used for changeType in setNeedsStyleRecalc. It is made non-default here in order to enforce a more conscious choice when adding calls to setNeedsStyleRecalc. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Element.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 10 months ago (2014-02-03 11:44:13 UTC) #1
kenneth.r.christiansen
Good idea, I like this
6 years, 10 months ago (2014-02-03 11:53:37 UTC) #2
ojan
lgtm
6 years, 10 months ago (2014-02-03 19:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/152623002/1
6 years, 10 months ago (2014-02-03 19:40:09 UTC) #4
commit-bot: I haz the power
Change committed as 166335
6 years, 10 months ago (2014-02-03 22:20:07 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:20:13 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:20:17 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 22:20:52 UTC) #8
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698