Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: Source/core/html/HTMLTableElement.cpp

Issue 152623002: Make StyleChange parameter explicit in setNeedsStyleRecalc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 bool cellChanged = false; 264 bool cellChanged = false;
265 265
266 if (n->hasTagName(tdTag)) 266 if (n->hasTagName(tdTag))
267 cellChanged = true; 267 cellChanged = true;
268 else if (isTableCellAncestor(n)) { 268 else if (isTableCellAncestor(n)) {
269 for (Node* child = n->firstChild(); child; child = child->nextSibling()) 269 for (Node* child = n->firstChild(); child; child = child->nextSibling())
270 cellChanged |= setTableCellsChanged(child); 270 cellChanged |= setTableCellsChanged(child);
271 } 271 }
272 272
273 if (cellChanged) 273 if (cellChanged)
274 n->setNeedsStyleRecalc(); 274 n->setNeedsStyleRecalc(SubtreeStyleChange);
275 275
276 return cellChanged; 276 return cellChanged;
277 } 277 }
278 278
279 static bool getBordersFromFrameAttributeValue(const AtomicString& value, bool& b orderTop, bool& borderRight, bool& borderBottom, bool& borderLeft) 279 static bool getBordersFromFrameAttributeValue(const AtomicString& value, bool& b orderTop, bool& borderRight, bool& borderBottom, bool& borderLeft)
280 { 280 {
281 borderTop = false; 281 borderTop = false;
282 borderRight = false; 282 borderRight = false;
283 borderBottom = false; 283 borderBottom = false;
284 borderLeft = false; 284 borderLeft = false;
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 // ### 404 // ###
405 } else 405 } else
406 HTMLElement::parseAttribute(name, value); 406 HTMLElement::parseAttribute(name, value);
407 407
408 if (bordersBefore != cellBorders() || oldPadding != m_padding) { 408 if (bordersBefore != cellBorders() || oldPadding != m_padding) {
409 m_sharedCellStyle = 0; 409 m_sharedCellStyle = 0;
410 bool cellChanged = false; 410 bool cellChanged = false;
411 for (Node* child = firstChild(); child; child = child->nextSibling()) 411 for (Node* child = firstChild(); child; child = child->nextSibling())
412 cellChanged |= setTableCellsChanged(child); 412 cellChanged |= setTableCellsChanged(child);
413 if (cellChanged) 413 if (cellChanged)
414 setNeedsStyleRecalc(); 414 setNeedsStyleRecalc(SubtreeStyleChange);
415 } 415 }
416 } 416 }
417 417
418 static PassRefPtr<StylePropertySet> createBorderStyle(CSSValueID value) 418 static PassRefPtr<StylePropertySet> createBorderStyle(CSSValueID value)
419 { 419 {
420 RefPtr<MutableStylePropertySet> style = MutableStylePropertySet::create(); 420 RefPtr<MutableStylePropertySet> style = MutableStylePropertySet::create();
421 style->setProperty(CSSPropertyBorderTopStyle, value); 421 style->setProperty(CSSPropertyBorderTopStyle, value);
422 style->setProperty(CSSPropertyBorderBottomStyle, value); 422 style->setProperty(CSSPropertyBorderBottomStyle, value);
423 style->setProperty(CSSPropertyBorderLeftStyle, value); 423 style->setProperty(CSSPropertyBorderLeftStyle, value);
424 style->setProperty(CSSPropertyBorderRightStyle, value); 424 style->setProperty(CSSPropertyBorderRightStyle, value);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 { 567 {
568 return getAttribute(rulesAttr); 568 return getAttribute(rulesAttr);
569 } 569 }
570 570
571 const AtomicString& HTMLTableElement::summary() const 571 const AtomicString& HTMLTableElement::summary() const
572 { 572 {
573 return getAttribute(summaryAttr); 573 return getAttribute(summaryAttr);
574 } 574 }
575 575
576 } 576 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698