Fix paint code so that overlays and views paint their own layers.

Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense because
the link highlights belong to the page content and hang off of it.

BUG=570112
Committed: https://crrev.com/08fbbc6a745869964f927f436e64c140fc04abb5
Cr-Commit-Position: refs/heads/master@{#365850}

[chrishtr, 2015-12-16 22:05:24]

Description was changed from

==========
none


Merge branch 'master' into fixgraphicslayers


none

BUG=
==========

to

==========
Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense
because
the link highlights belong to the page content and hang off of it.


BUG=570112
==========

[chrishtr, 2015-12-16 22:29:20]

Description was changed from

==========
Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense
because
the link highlights belong to the page content and hang off of it.


BUG=570112
==========

to

==========
Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense
because
the link highlights belong to the page content and hang off of it.


BUG=570112
==========

[chrishtr, 2015-12-16 22:32:00]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org, wkorman@chromium.org

[chrishtr, 2015-12-16 22:32:01]

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
(left):

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp:702:
if (m_overflowControlsHostLayer)
See PaintLayerCompositor::ensureRootLayer. This conditional is always true.

[wkorman, 2015-12-16 23:29:54]

lgtm

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebViewImpl.cpp:2008: if
(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
Do things still work the old way with this flag off and the other changes in
this CL?

Maybe we can just remove the flag soon since it's on in stable?

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebViewImpl.cpp:2017: 
-1 blank

[Xianzhu, 2015-12-16 23:45:39]

lgtm

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebViewImpl.cpp:2008: if
(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
On 2015/12/16 23:29:54, wkorman wrote:
> Do things still work the old way with this flag off and the other changes in
> this CL?
> 
> Maybe we can just remove the flag soon since it's on in stable?

There are still several regressions. Keeping the old way can help debugging the
regressions. We can remove the flag after all regressions are fixed and no new
discovered regressions after some time.

[chrishtr, 2015-12-16 23:51:33]

I also updated the ASCII diagram some more in VisualViewport.

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebViewImpl.cpp:2008: if
(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
On 2015/12/16 at 23:29:54, wkorman wrote:
> Do things still work the old way with this flag off and the other changes in
this CL?
> 
> Maybe we can just remove the flag soon since it's on in stable?

I think so yes. I'll do some quick manual testing.

https://codereview.chromium.org/1526093006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebViewImpl.cpp:2017: 
On 2015/12/16 at 23:29:54, wkorman wrote:
> -1 blank

Fixed.

[chrishtr, 2015-12-17 00:42:18]

Turns out link highlights currently don't paint themselves. Added a todo for
this.
Also fixed the tests to use a mock scrollbar theme.

[chrishtr, 2015-12-17 00:42:21]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-12-17 00:42:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1526093006/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 00:44:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526093006/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526093006/180001

[commit-bot: I haz the power, 2015-12-17 02:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 02:44:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2015-12-17 16:50:41]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-12-17 16:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1526093006/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 16:50:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1526093006/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1526093006/200001

[commit-bot: I haz the power, 2015-12-17 17:54:26]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-12-17 17:55:10]

Description was changed from

==========
Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense
because
the link highlights belong to the page content and hang off of it.


BUG=570112
==========

to

==========
Fix paint code so that overlays and views paint their own layers.

Previously, in synchronized paint mode, the root FrameView of the page painted
everything, including page overlays for the inspector, solid colors and link
highlights.

Now the inspector and solid color overlays are painted by their own code. This
allows us to clean up the lifecycle code in WebViewImpl and also make it faster.

Link highlights are still painted by the root frame view, which makes sense
because
the link highlights belong to the page content and hang off of it.

BUG=570112

Committed: https://crrev.com/08fbbc6a745869964f927f436e64c140fc04abb5
Cr-Commit-Position: refs/heads/master@{#365850}
==========

[commit-bot: I haz the power, 2015-12-17 17:55:10]

Patchset 11 (id:??) landed as
https://crrev.com/08fbbc6a745869964f927f436e64c140fc04abb5
Cr-Commit-Position: refs/heads/master@{#365850}