Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1526093006: Fix paint code so that overlays and views paint their own layers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 } 217 }
218 218
219 void InspectorOverlay::invalidate() 219 void InspectorOverlay::invalidate()
220 { 220 {
221 if (!m_pageOverlay) 221 if (!m_pageOverlay)
222 m_pageOverlay = PageOverlay::create(m_webViewImpl, new InspectorPageOver layDelegate(*this)); 222 m_pageOverlay = PageOverlay::create(m_webViewImpl, new InspectorPageOver layDelegate(*this));
223 223
224 m_pageOverlay->update(); 224 m_pageOverlay->update();
225 } 225 }
226 226
227 void InspectorOverlay::layout() 227 void InspectorOverlay::updateAllLifecyclePhases()
228 { 228 {
229 if (isEmpty()) 229 if (isEmpty())
230 return; 230 return;
231 231
232 TemporaryChange<bool> scoped(m_inLayout, true); 232 TemporaryChange<bool> scoped(m_inLayout, true);
233 if (m_needsUpdate) { 233 if (m_needsUpdate) {
234 m_needsUpdate = false; 234 m_needsUpdate = false;
235 rebuildOverlayPage(); 235 rebuildOverlayPage();
236 } 236 }
237 overlayMainFrame()->view()->updateAllLifecyclePhases(); 237 overlayMainFrame()->view()->updateAllLifecyclePhases();
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 747
748 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node) 748 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node)
749 { 749 {
750 if (m_inspectMode != InspectorDOMAgent::ShowLayoutEditor || !node || !node-> isElementNode() || !node->ownerDocument()->isActive()) 750 if (m_inspectMode != InspectorDOMAgent::ShowLayoutEditor || !node || !node-> isElementNode() || !node->ownerDocument()->isActive())
751 return; 751 return;
752 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_domAgen t, &overlayMainFrame()->script()); 752 m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_domAgen t, &overlayMainFrame()->script());
753 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridde n(true); 753 toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridde n(true);
754 } 754 }
755 755
756 } // namespace blink 756 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698