Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1525953002:
Fix flaky logo spin animation restart logic (Closed)
|
Created:
5 years ago by alancutter (OOO until 2018) Modified:
4 years, 12 months ago CC:
arv+watch_chromium.org, chromium-reviews, dstockwell, loyso (OOO), samli, shans Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix flaky logo spin animation restart logic
This change updates the click handler for the Chrome logo in the help
page to force a style recalc between removing the "spin" class and
adding it back again. This ensures that any running animations are
cancelled and a new animation starts.
Previously the code was relying on setTimeout() to wait for a style
recalc which was never guaranteed thus the animation would not always
restart.
BUG=568485
Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0
Cr-Commit-Position: refs/heads/master@{#365242}
Committed: https://crrev.com/27488e4a2d0e56e8e193df0e4c1e4792972d0c32
Cr-Commit-Position: refs/heads/master@{#365440}
Patch Set 1 #Patch Set 2 : Add warning suppression #Patch Set 3 : Call getter instead of reading property #Messages
Total messages: 25 (11 generated)
Description was changed from ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. BUG=568485 ========== to ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. Previously the code was relying on setTimeout() to wait for a style recalc which was never guaranteed thus the animation would not always restart. BUG=568485 ==========
alancutter@chromium.org changed reviewers: + dbeam@chromium.org
samli@chromium.org changed reviewers: + samli@chromium.org
lgtm
alancutter@chromium.org changed reviewers: + bauerb@chromium.org
Looks like dbeam is OOO for a while. +bauerb are you able to review this in their absence?
lgtm
The CQ bit was checked by alancutter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525953002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. Previously the code was relying on setTimeout() to wait for a style recalc which was never guaranteed thus the animation would not always restart. BUG=568485 ========== to ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. Previously the code was relying on setTimeout() to wait for a style recalc which was never guaranteed thus the animation would not always restart. BUG=568485 Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0 Cr-Commit-Position: refs/heads/master@{#365242} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0 Cr-Commit-Position: refs/heads/master@{#365242}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1530773002/ by alancutter@chromium.org. The reason for reverting is: Broke the closure compiler. http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Lin... ERROR - Suspicious code. The result of the 'getprop' operator is not being used. ## getComputedStyle(logo).animationName; ## ^ ## .
The CQ bit was checked by alancutter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org, samli@chromium.org Link to the patchset: https://codereview.chromium.org/1525953002/#ps40001 (title: "Call getter instead of reading property")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525953002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alancutter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525953002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. Previously the code was relying on setTimeout() to wait for a style recalc which was never guaranteed thus the animation would not always restart. BUG=568485 Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0 Cr-Commit-Position: refs/heads/master@{#365242} ========== to ========== Fix flaky logo spin animation restart logic This change updates the click handler for the Chrome logo in the help page to force a style recalc between removing the "spin" class and adding it back again. This ensures that any running animations are cancelled and a new animation starts. Previously the code was relying on setTimeout() to wait for a style recalc which was never guaranteed thus the animation would not always restart. BUG=568485 Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0 Cr-Commit-Position: refs/heads/master@{#365242} Committed: https://crrev.com/27488e4a2d0e56e8e193df0e4c1e4792972d0c32 Cr-Commit-Position: refs/heads/master@{#365440} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/27488e4a2d0e56e8e193df0e4c1e4792972d0c32 Cr-Commit-Position: refs/heads/master@{#365440}
Message was sent while issue was closed.
lgtm! |
