chrome/browser/resources/help/help_page.js - Issue 1525953002: Fix flaky logo spin animation restart logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/help/help_page.js

Issue 1525953002: Fix flaky logo spin animation restart logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call getter instead of reading property Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/help/help_page.js

diff --git a/chrome/browser/resources/help/help_page.js b/chrome/browser/resources/help/help_page.js

index 7e075f2bafce6c85dc9b54f8e86b1e86b7e5568d..4269098fc154ce0fcf518eba84595ac3f231e0cf 100644

--- a/chrome/browser/resources/help/help_page.js

+++ b/chrome/browser/resources/help/help_page.js

@@ -165,7 +165,9 @@ cr.define('help', function() {

var logo = $('product-logo');

logo.onclick = function(e) {

logo.classList.remove('spin');

- setTimeout(function() { logo.classList.add('spin'); }, 0);

+ // Force a style recalc that cancels the animation specified by "spin".

+ getComputedStyle(logo).getPropertyValue('animation-name');

+ logo.classList.add('spin');

};

// Attempt to update.

« no previous file with comments | « no previous file | no next file » | no next file with comments »