Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1525783002: cc: widen threshold for background filter pixeltests on Windows. (Closed)

Created:
5 years ago by Stephen White
Modified:
5 years ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: widen threshold for background filter pixeltests on Windows. The pixel diffs from Windows <-> Linux are wider after https://codereview.chromium.org/1513283003/. R=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://chromium.googlesource.com/chromium/src/+/8eb71d6d1855470204f877acec2144178e8ac3d1

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M cc/trees/layer_tree_host_pixeltest_filters.cc View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525783002/20001
5 years ago (2015-12-14 21:28:07 UTC) #3
Stephen White
danakj@: PTAL. Thanks!
5 years ago (2015-12-14 21:37:05 UTC) #4
danakj
LGTM https://codereview.chromium.org/1525783002/diff/20001/cc/trees/layer_tree_host_pixeltest_filters.cc File cc/trees/layer_tree_host_pixeltest_filters.cc (right): https://codereview.chromium.org/1525783002/diff/20001/cc/trees/layer_tree_host_pixeltest_filters.cc#newcode389 cc/trees/layer_tree_host_pixeltest_filters.cc:389: float percentage_pixels_large_error = 2.6f; // 994px / (200*200) ...
5 years ago (2015-12-14 21:40:59 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8eb71d6d1855470204f877acec2144178e8ac3d1 Cr-Commit-Position: refs/heads/master@{#365105}
5 years ago (2015-12-14 21:44:03 UTC) #7
Stephen White
5 years ago (2015-12-14 21:44:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8eb71d6d1855470204f877acec2144178e8ac3d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698