Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: cc/trees/layer_tree_host_pixeltest_filters.cc

Issue 1525783002: cc: widen threshold for background filter pixeltests on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_pixeltest_filters.cc
diff --git a/cc/trees/layer_tree_host_pixeltest_filters.cc b/cc/trees/layer_tree_host_pixeltest_filters.cc
index bd38dd0a8583e723aa6c5497cef0193089135e84..33a76830ab229051d1560f0545d0bb835fb0defb 100644
--- a/cc/trees/layer_tree_host_pixeltest_filters.cc
+++ b/cc/trees/layer_tree_host_pixeltest_filters.cc
@@ -75,8 +75,8 @@ TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlurOutsets) {
blur->SetBackgroundFilters(filters);
#if defined(OS_WIN)
- // Windows has 2596 pixels off by at most 2: crbug.com/259922
- float percentage_pixels_large_error = 6.5f; // 2596px / (200*200), rounded up
+ // Windows has 7.6975% pixels by at most 2: crbug.com/259922
+ float percentage_pixels_large_error = 7.7f;
float percentage_pixels_small_error = 0.0f;
float average_error_allowed_in_bad_pixels = 1.f;
int large_error_allowed = 2;
@@ -385,8 +385,8 @@ class ImageBackgroundFilter : public LayerTreeHostFiltersPixelTest {
filter->SetBackgroundFilters(filters);
#if defined(OS_WIN)
- // Windows has 994 pixels off by at most 2: crbug.com/225027
- float percentage_pixels_large_error = 2.5f; // 994px / (200*200)
+ // Windows has 2.5875% pixels off by at most 2: crbug.com/225027
+ float percentage_pixels_large_error = 2.6f; // 994px / (200*200)
danakj 2015/12/14 21:40:59 this comment is wrong now?
float percentage_pixels_small_error = 0.0f;
float average_error_allowed_in_bad_pixels = 1.f;
int large_error_allowed = 2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698