Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1524923002:
Use rpath for sanitizers. (Closed)
|
Created:
5 years ago by brettw Modified:
5 years ago Reviewers:
Dirk Pranke CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@rpath Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse rpath for sanitizers.
This allows it to find libc++ in the current directory in static sanitizer builds.
TBR=dpranke@chromium.org
BUG=569344
Committed: https://crrev.com/b65f55a2241d90d6df46c67167fed1eb8b4bba91
Cr-Commit-Position: refs/heads/master@{#365136}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 19 (11 generated)
Description was changed from ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. R=dpranke@chromium.org ========== to ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. R=dpranke@chromium.org BUG=569344 ==========
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524923002/1
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1525773002 Patch 40001). Please resolve the dependency and try again.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524923002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. R=dpranke@chromium.org BUG=569344 ========== to ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. TBR=dpranke@chromium.org BUG=569344 ==========
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524923002/1
Message was sent while issue was closed.
Description was changed from ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. TBR=dpranke@chromium.org BUG=569344 ========== to ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. TBR=dpranke@chromium.org BUG=569344 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. TBR=dpranke@chromium.org BUG=569344 ========== to ========== Use rpath for sanitizers. This allows it to find libc++ in the current directory in static sanitizer builds. TBR=dpranke@chromium.org BUG=569344 Committed: https://crrev.com/b65f55a2241d90d6df46c67167fed1eb8b4bba91 Cr-Commit-Position: refs/heads/master@{#365136} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b65f55a2241d90d6df46c67167fed1eb8b4bba91 Cr-Commit-Position: refs/heads/master@{#365136} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
