Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart

Issue 1525713002: fix CombinatorContributor to only suggest public members (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
index 25e61e4ae3118b14305f0f7658f34261d79bf524..921525bb7b5e91a4f71241347224f43d386f5a6a 100644
--- a/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart
@@ -94,7 +94,8 @@ class CombinatorContributorTest extends DartCompletionContributorTest {
library libAB;
part '/partAB.dart';
class A { }
- class B { }''');
+ class B { }
+ class _AB''');
addSource(
'/partAB.dart',
'''
@@ -124,6 +125,7 @@ class CombinatorContributorTest extends DartCompletionContributorTest {
assertSuggestClass('B',
relevance: DART_RELEVANCE_DEFAULT,
kind: CompletionSuggestionKind.IDENTIFIER);
+ assertNotSuggested('_AB');
assertSuggestClass('PB',
relevance: DART_RELEVANCE_DEFAULT,
kind: CompletionSuggestionKind.IDENTIFIER);
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698