Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

Issue 1525713002: fix CombinatorContributor to only suggest public members (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
index a08b8bb30c0fa66fc2079aea8c7f1ee73546f27d..d7bf1ea2b4cba0e1e1994770b1d1e42a1472be54 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart
@@ -32,8 +32,8 @@ class CombinatorContributor extends DartCompletionContributor {
LibraryElement library = directive.uriElement;
if (library != null) {
LibraryElementSuggestionBuilder builder =
- new LibraryElementSuggestionBuilder(
- library, CompletionSuggestionKind.IDENTIFIER, false, false);
+ new LibraryElementSuggestionBuilder(request.libraryElement,
+ CompletionSuggestionKind.IDENTIFIER, false, false);
library.visitChildren(builder);
return builder.suggestions;
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698