DescriptionRemove an unneeded std::move(), found by clang/win.
https://codereview.chromium.org/1530923002 changed this from a Pass() to
std::move(), which has the effect that the compiler can now reason about it
and is able to point out:
..\..\ui\gfx\win\direct_manipulation.cc(21,10) : error: moving a local object
in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(instance);
^
..\..\ui\gfx\win\direct_manipulation.cc(21,10) : note: remove std::move
call here
return std::move(instance);
^~~~~~~~~~
BUG=82385
TBR=avi@chromium.org
Committed: https://crrev.com/0eac2435210f650ceba686aad370bfaca915ca7b
Cr-Commit-Position: refs/heads/master@{#365811}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|