Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1525293004: Remove an unneeded std::move(), found by clang/win. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mkollaro
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unneeded std::move(), found by clang/win. https://codereview.chromium.org/1530923002 changed this from a Pass() to std::move(), which has the effect that the compiler can now reason about it and is able to point out: ..\..\ui\gfx\win\direct_manipulation.cc(21,10) : error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] return std::move(instance); ^ ..\..\ui\gfx\win\direct_manipulation.cc(21,10) : note: remove std::move call here return std::move(instance); ^~~~~~~~~~ BUG=82385 TBR=avi@chromium.org Committed: https://crrev.com/0eac2435210f650ceba686aad370bfaca915ca7b Cr-Commit-Position: refs/heads/master@{#365811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/win/direct_manipulation.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years ago (2015-12-17 12:00:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525293004/1
5 years ago (2015-12-17 12:02:05 UTC) #3
Nico
Committed patchset #1 (id:1) to pending queue manually as 6db29a98ac24d0f9ad3278f4859643fe9d26860f (presubmit successful).
5 years ago (2015-12-17 12:13:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0eac2435210f650ceba686aad370bfaca915ca7b Cr-Commit-Position: refs/heads/master@{#365811}
5 years ago (2015-12-17 12:14:09 UTC) #6
Avi (use Gerrit)
5 years ago (2015-12-17 15:02:56 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698