Replace Pass() with std::move in ui/gl and ui/gfx

Replace Pass() with std::move in ui/gl and ui/gfx

Remove it completely when copy ellision can take care of it.

BUG=557422
Committed: https://crrev.com/66bdb2b67a8642ec923485f899f1658b27b0cc05
Cr-Commit-Position: refs/heads/master@{#365785}

[mkollaro, 2015-12-16 14:56:25]

martina.kollarova@intel.com changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-12-16 15:06:02]

lgtm

stampity stamp

[mkollaro, 2015-12-17 08:27:35]

The CQ bit was checked by martina.kollarova@intel.com

[commit-bot: I haz the power, 2015-12-17 08:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530923002/1

[commit-bot: I haz the power, 2015-12-17 08:35:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-17 08:37:52]

Description was changed from

==========
Replace Pass() with std::move in ui/gl and ui/gfx

Remove it completely when copy ellision can take care of it.

BUG=557422
==========

to

==========
Replace Pass() with std::move in ui/gl and ui/gfx

Remove it completely when copy ellision can take care of it.

BUG=557422

Committed: https://crrev.com/66bdb2b67a8642ec923485f899f1658b27b0cc05
Cr-Commit-Position: refs/heads/master@{#365785}
==========

[commit-bot: I haz the power, 2015-12-17 08:37:52]

Patchset 1 (id:??) landed as
https://crrev.com/66bdb2b67a8642ec923485f899f1658b27b0cc05
Cr-Commit-Position: refs/heads/master@{#365785}

[Nico, 2015-12-17 11:57:54]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-12-17 11:57:54]

https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
File ui/gfx/win/direct_manipulation.cc (right):

https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
ui/gfx/win/direct_manipulation.cc:21: return std::move(instance);
You forgot to remove it here. clang/win complains:

..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  error: moving a local object
in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(instance);
         ^
..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  note: remove std::move call
here
  return std::move(instance);
         ^~~~~~~~~~        ~
1 error generated.

I'll take care of it. (If you build on Windows, see
https://chromium.googlesource.com/chromium/src/+/master/docs/clang.md for how
you can use clang for local development.)

[mkollaro, 2015-12-22 15:32:21]

On 2015/12/17 11:57:54, Nico wrote:
>
https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
> File ui/gfx/win/direct_manipulation.cc (right):
> 
>
https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
> ui/gfx/win/direct_manipulation.cc:21: return std::move(instance);
> You forgot to remove it here. clang/win complains:
> 
> ..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  error: moving a local object
> in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
>   return std::move(instance);
>          ^
> ..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  note: remove std::move call
> here
>   return std::move(instance);
>          ^~~~~~~~~~        ~
> 1 error generated.
> 
> I'll take care of it. (If you build on Windows, see
> https://chromium.googlesource.com/chromium/src/+/master/docs/clang.md for how
> you can use clang for local development.)

Sorry, I thought compiling it on Linux with clang would catch it all. Thanks for
fixing it.

[Nico, 2015-12-22 15:34:23]

On 2015/12/22 15:32:21, mkollaro wrote:
> On 2015/12/17 11:57:54, Nico wrote:
> >
>
https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
> > File ui/gfx/win/direct_manipulation.cc (right):
> > 
> >
>
https://codereview.chromium.org/1530923002/diff/1/ui/gfx/win/direct_manipulat...
> > ui/gfx/win/direct_manipulation.cc:21: return std::move(instance);
> > You forgot to remove it here. clang/win complains:
> > 
> > ..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  error: moving a local
object
> > in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
> >   return std::move(instance);
> >          ^
> > ..\..\ui\gfx\win\direct_manipulation.cc(21,10) :  note: remove std::move
call
> > here
> >   return std::move(instance);
> >          ^~~~~~~~~~        ~
> > 1 error generated.
> > 
> > I'll take care of it. (If you build on Windows, see
> > https://chromium.googlesource.com/chromium/src/+/master/docs/clang.md for
how
> > you can use clang for local development.)
> 
> Sorry, I thought compiling it on Linux with clang would catch it all. Thanks
for
> fixing it.

Compiling on linux won't check any _win files (or _mac files).