Revert of Remove ScopedVector from url_request_context_builder

Revert of Remove ScopedVector from url_request_context_builder (patchset #2 id:20001 of https://codereview.chromium.org/1504383002/ )

Reason for revert:
broke compile on all cronet builders, see crbug.com/569978

Original issue's description:
> Remove ScopedVector from url_request_context_builder
>
> Also added missing include to
> chrome/test/chromedriver/net/url_request_context_getter.cc
>
> TBR=samuong@chromium.org
>
> BUG=554289
>
> Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
> Cr-Commit-Position: refs/heads/master@{#365221}

TBR=rsleevi@chromium.org,samuong@chromium.org,jochen@chromium.org,olli.raula@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554289
Committed: https://crrev.com/ad3c734a7436a77d07b59e16c360482caa77c638
Cr-Commit-Position: refs/heads/master@{#365300}

[timvolodine, 2015-12-15 18:51:37]

Created Revert of Remove ScopedVector from url_request_context_builder

[commit-bot: I haz the power, 2015-12-15 18:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525263003/1

[commit-bot: I haz the power, 2015-12-15 18:55:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-15 18:57:31]

Description was changed from

==========
Revert of Remove ScopedVector from url_request_context_builder (patchset #2
id:20001 of https://codereview.chromium.org/1504383002/ )

Reason for revert:
broke compile on all cronet builders, see crbug.com/569978

Original issue's description:
> Remove ScopedVector from url_request_context_builder
> 
> Also added missing include to
> chrome/test/chromedriver/net/url_request_context_getter.cc
> 
> TBR=samuong@chromium.org
> 
> BUG=554289
> 
> Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
> Cr-Commit-Position: refs/heads/master@{#365221}

TBR=rsleevi@chromium.org,samuong@chromium.org,jochen@chromium.org,olli.raula@...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554289
==========

to

==========
Revert of Remove ScopedVector from url_request_context_builder (patchset #2
id:20001 of https://codereview.chromium.org/1504383002/ )

Reason for revert:
broke compile on all cronet builders, see crbug.com/569978

Original issue's description:
> Remove ScopedVector from url_request_context_builder
>
> Also added missing include to
> chrome/test/chromedriver/net/url_request_context_getter.cc
>
> TBR=samuong@chromium.org
>
> BUG=554289
>
> Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
> Cr-Commit-Position: refs/heads/master@{#365221}

TBR=rsleevi@chromium.org,samuong@chromium.org,jochen@chromium.org,olli.raula@...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554289

Committed: https://crrev.com/ad3c734a7436a77d07b59e16c360482caa77c638
Cr-Commit-Position: refs/heads/master@{#365300}
==========

[commit-bot: I haz the power, 2015-12-15 18:57:32]

Patchset 1 (id:??) landed as
https://crrev.com/ad3c734a7436a77d07b59e16c360482caa77c638
Cr-Commit-Position: refs/heads/master@{#365300}

[Ryan Sleevi, 2015-12-15 19:06:37]

Is Cronet on the trybots?
Is Cronet on the main waterfall?

If not, then reverting because this broke does not seem appropriate; if Cronet
is still on a 'best-effort' building wise, then the bot owners should fix
breakages, rather than reverting.

[timvolodine, 2015-12-15 19:15:23]

On 2015/12/15 19:06:37, Ryan Sleevi wrote:
> Is Cronet on the trybots?
> Is Cronet on the main waterfall?
> 
> If not, then reverting because this broke does not seem appropriate; if Cronet
> is still on a 'best-effort' building wise, then the bot owners should fix
> breakages, rather than reverting.

cronet is on chromium.android waterfall

[timvolodine, 2015-12-15 19:25:37]

On 2015/12/15 19:15:23, timvolodine wrote:
> On 2015/12/15 19:06:37, Ryan Sleevi wrote:
> > Is Cronet on the trybots?
> > Is Cronet on the main waterfall?
> > 
> > If not, then reverting because this broke does not seem appropriate; if
Cronet
> > is still on a 'best-effort' building wise, then the bot owners should fix
> > breakages, rather than reverting.
> 
> cronet is on chromium.android waterfall

sorry if this revert looks too aggressive, since the change is very minor and it
look like the only user of the interface is cronet thought it would make sense
to be part of this patch.

[Ryan Sleevi, 2015-12-15 19:29:02]

On 2015/12/15 19:25:37, timvolodine wrote:
> sorry if this revert looks too aggressive, since the change is very minor and
it
> look like the only user of the interface is cronet thought it would make sense
> to be part of this patch.

The problem is that there appears to be no way to reasonably test the fix as an
external contributor, which is why it's problematic to revert and ask them to
fix something they can't see, nor are there trybots to test the fix (as far as I
can tell)