Remove ScopedVector from url_request_context_builder

Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289
Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
Cr-Commit-Position: refs/heads/master@{#365221}

[Olli Raula, 2015-12-09 11:05:36]

Description was changed from

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

 BUG=554289
==========

to

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

 BUG=554289
==========

[Olli Raula, 2015-12-09 11:05:37]

olli.raula@intel.com changed reviewers:
+ rsleevi@chromium.org

[Olli Raula, 2015-12-09 11:07:56]

olli.raula@intel.com changed reviewers:
+ samuong@chromium.org

[Olli Raula, 2015-12-09 11:08:12]

Could you review?

[Ryan Sleevi, 2015-12-09 18:19:43]

Description was changed from

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

 BUG=554289
==========

to

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

BUG=554289
==========

[Ryan Sleevi, 2015-12-09 18:20:22]

lgtm

https://codereview.chromium.org/1504383002/diff/1/net/url_request/url_request...
File net/url_request/url_request_context_builder.cc (right):

https://codereview.chromium.org/1504383002/diff/1/net/url_request/url_request...
net/url_request/url_request_context_builder.cc:463: for
(std::vector<scoped_ptr<net::URLRequestInterceptor>>::reverse_iterator
for (auto i = url_request_interceptors_.rbegin(); i !=
url_request_interceptors_.rend(); ++i) {

[Olli Raula, 2015-12-11 07:43:25]

Done, samuongs approval missing or if rsleevi is ok for tbr, then I can do that
as well.

[Olli Raula, 2015-12-15 07:12:26]

olli.raula@intel.com changed reviewers:
+ jochen@chromium.org

[Olli Raula, 2015-12-15 07:13:39]

Jochen: could you check added include in url_request_context_getter.cc as more
near owners are OOO or something.

[Ryan Sleevi, 2015-12-15 08:16:56]

On 2015/12/15 07:13:39, Olli Raula wrote:
> Jochen: could you check added include in url_request_context_getter.cc as more
> near owners are OOO or something.

For a simple include change like that, it's fine to TBR the owner. The meat in
//net still LGTM

[Olli Raula, 2015-12-15 09:02:10]

Description was changed from

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

BUG=554289
==========

to

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289
==========

[Olli Raula, 2015-12-15 09:02:32]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-12-15 09:04:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504383002/20001

[commit-bot: I haz the power, 2015-12-15 10:16:29]

Description was changed from

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289
==========

to

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289
==========

[commit-bot: I haz the power, 2015-12-15 10:16:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 10:17:11]

Description was changed from

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289
==========

to

==========
Remove ScopedVector from url_request_context_builder

Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc

TBR=samuong@chromium.org

BUG=554289

Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
Cr-Commit-Position: refs/heads/master@{#365221}
==========

[commit-bot: I haz the power, 2015-12-15 10:17:12]

Patchset 2 (id:??) landed as
https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
Cr-Commit-Position: refs/heads/master@{#365221}

[timvolodine, 2015-12-15 18:51:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1525263003/ by timvolodine@chromium.org.

The reason for reverting is: broke compile on all cronet builders, see
crbug.com/569978.

[timvolodine, 2015-12-15 19:05:51]

On 2015/12/15 18:51:36, timvolodine wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1525263003/ by
mailto:timvolodine@chromium.org.
> 
> The reason for reverting is: broke compile on all cronet builders, see
> crbug.com/569978.

looks like src/components/cronet/android/cronet_url_request_context_adapter.cc
needs some updating, could you please reland with the update..