Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1525173003: [debugger] remove step count parameter from prepare step. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove step count parameter from prepare step. And tons of changes to debugger tests. R=bmeurer@chromium.org BUG=chromium:569835 LOG=N Committed: https://crrev.com/8bee91a58b37e9030ddf7b43cb9c24e5df7b96a2 Cr-Commit-Position: refs/heads/master@{#32885}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -310 lines) Patch
M src/debug/debug.js View 3 chunks +9 lines, -17 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +3 lines, -10 lines 1 comment Download
M test/mjsunit/debug-allscopes-on-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-break-native.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-continue.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-stepin.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-return-value.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-step.js View 2 chunks +5 lines, -16 lines 0 comments Download
M test/mjsunit/debug-step-4.js View 3 chunks +3 lines, -9 lines 0 comments Download
M test/mjsunit/debug-step-end-of-script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-step-into-json.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/debug-step-into-valueof.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-step-turbofan.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepframe.js View 2 chunks +9 lines, -12 lines 0 comments Download
M test/mjsunit/debug-stepframe-clearing.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-stepin-accessor.js View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/debug-stepin-accessor-ic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepin-builtin.js View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/debug-stepin-builtin-callback.js View 1 chunk +72 lines, -85 lines 0 comments Download
M test/mjsunit/debug-stepin-builtin-callback-opt.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepin-call-function-stub.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/debug-stepin-construct-call.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepin-foreach.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepin-function-call.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/debug-stepin-property-function-call.js View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/debug-stepout-recursive-function.js View 3 chunks +3 lines, -8 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part5.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part6.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part7.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part8.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepout-to-builtin.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/es6/debug-break-default-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/stepin-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/stepin-handler.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-step-into-class-extends.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-step-into-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-step-into-regexp-subclass.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-collections-foreach.js View 1 chunk +53 lines, -71 lines 0 comments Download
M test/mjsunit/es6/debug-stepin-generators.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-microtasks.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-stepin-string-template.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepnext-for.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-468661.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/debug-stepin-default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/debug-stepin-proxies.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/debug-prepare-step-in.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-109195.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-147497.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-119800.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-405922.js View 2 chunks +4 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-409614.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-467180.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-568477-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-568477-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-568477-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-568477-4.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years ago (2015-12-16 07:59:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525173003/1
5 years ago (2015-12-16 08:00:46 UTC) #3
Benedikt Meurer
LGTM with nit (feel free to ignore) https://codereview.chromium.org/1525173003/diff/1/src/runtime/runtime-debug.cc File src/runtime/runtime-debug.cc (right): https://codereview.chromium.org/1525173003/diff/1/src/runtime/runtime-debug.cc#newcode1215 src/runtime/runtime-debug.cc:1215: DCHECK(args.length() == ...
5 years ago (2015-12-16 08:03:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 08:19:41 UTC) #6
Yang
On 2015/12/16 08:19:41, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-16 08:35:01 UTC) #7
Yang
On 2015/12/16 08:35:01, Yang wrote: > On 2015/12/16 08:19:41, commit-bot: I haz the power wrote: ...
5 years ago (2015-12-16 08:35:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525173003/1
5 years ago (2015-12-16 08:35:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 08:39:42 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-16 08:40:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bee91a58b37e9030ddf7b43cb9c24e5df7b96a2
Cr-Commit-Position: refs/heads/master@{#32885}

Powered by Google App Engine
This is Rietveld 408576698