Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: test/mjsunit/debug-step.js

Issue 1525173003: [debugger] remove step count parameter from prepare step. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/debug-step.js
diff --git a/test/mjsunit/debug-step.js b/test/mjsunit/debug-step.js
index 45f077f9670d14a5e4b95511fa22dd5f46b7b619..bfbea16380cf7396c5c3571c55a0ba9f707d12ab 100644
--- a/test/mjsunit/debug-step.js
+++ b/test/mjsunit/debug-step.js
@@ -37,10 +37,10 @@ var bp1, bp2;
function listener(event, exec_state, event_data, data) {
if (event == Debug.DebugEvent.Break) {
- if (state == 0) {
- exec_state.prepareStep(Debug.StepAction.StepIn, 1000);
- state = 1;
- } else if (state == 1) {
+ if (step_count > 0) {
+ exec_state.prepareStep(Debug.StepAction.StepIn);
+ step_count--;
+ } else {
result = exec_state.frame().evaluate("i").value();
// Clear the break point on line 2 if set.
if (bp2) {
@@ -65,19 +65,8 @@ function f() {
bp1 = Debug.setBreakPoint(f, 1);
// Check that performing 1000 steps will make i 499.
-state = 0;
+var step_count = 1000;
result = -1;
f();
assertEquals(332, result);
-
-// Check that performing 1000 steps with a break point on the statement in the
-// for loop (line 2) will only make i 0 as a real break point breaks even when
-// multiple steps have been requested.
-state = 0;
-result = -1;
-bp2 = Debug.setBreakPoint(f, 3);
-f();
-assertEquals(0, result);
-
-// Get rid of the debug event listener.
Debug.setListener(null);

Powered by Google App Engine
This is Rietveld 408576698