Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1525163002: dart2js cps: Use oneshot interceptors and 'instanceof' expressions. (Closed)

Created:
5 years ago by asgerf
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Use oneshot interceptors and 'instanceof' expressions. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/488ffd8aac312d4912ccc03d8b41f0cdbf844083

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Add source info and ensure JS constructors get emitted #

Patch Set 4 : Update tests #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -27 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +15 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimize_interceptors.dart View 4 chunks +46 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 5 chunks +34 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 5 chunks +31 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
These don't always generate better code, but it is easier to compare with the old ...
5 years ago (2015-12-15 15:54:14 UTC) #2
sra1
lgtm
5 years ago (2015-12-15 21:54:01 UTC) #3
asgerf
5 years ago (2015-12-16 13:13:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
488ffd8aac312d4912ccc03d8b41f0cdbf844083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698