pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart - Issue 1525163002: dart2js cps: Use oneshot interceptors and 'instanceof' expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

Issue 1525163002: dart2js cps: Use oneshot interceptors and 'instanceof' expressions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

diff --git a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

index 27305149f664ee4d896eb843da59b602e064f0fa..3b3a74ae874fa04db860bb1af99cac927d353327 100644

--- a/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

+++ b/pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart

@@ -259,6 +259,12 @@ class PullIntoInitializers extends RecursiveTransformer

return node;

}

+ Expression visitOneShotInterceptor(OneShotInterceptor node) {

+ super.visitOneShotInterceptor(node);

+ ++impureCounter;

+ return node;

+ }

Expression visitConditional(Conditional node) {

node.condition = visitExpression(node.condition);

// Visit the branches to detect impure subexpressions, but do not pull