Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1525003002: Revert of Refactor MediaCodecBridge to add support for NDK APIs (Closed)

Created:
5 years ago by acleung1
Modified:
5 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor MediaCodecBridge to add support for NDK APIs (patchset #5 id:100001 of https://codereview.chromium.org/1472943002/ ) Reason for revert: This breaks 64bit ARM https://code.google.com/p/chromium/issues/detail?id=568923 Original issue's description: > Refactor MediaCodecBridge to add support for NDK APIs > > Currently MediaCodecBridge is implemented with android MediaCodec SDK API. > On android-21, MediaCodec NDK APIs have been added. > This CL makes MediaCodecBridge a common ancestor inherited by the > SDK and NDK implementation. > Some common java functions are moved to MediaCodecUtil.java. > The original native MediaCodecBridge class is renamed to > SdkMediaCodecBridge. > The NdkMediaCodecBridge is still WIP. > > BUG=560451 > > Committed: https://crrev.com/5d52e0f8e63a294179df028a0dabc76a042cf9ec > Cr-Commit-Position: refs/heads/master@{#363374} TBR=timav@chromium.org,xhwang@chromium.org,sievers@chromium.org,qinmin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560451 Committed: https://crrev.com/04baa92bc02e36182c623632f831c1b3411e8434 Cr-Commit-Position: refs/heads/master@{#365131}

Patch Set 1 #

Patch Set 2 : fix rebase errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1592 lines, -2127 lines) Patch
M components/cdm/browser/cdm_message_filter_android.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/avda_shared_state.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 1 chunk +0 lines, -9 lines 0 comments Download
M media/base/android/BUILD.gn View 1 4 chunks +1 line, -6 lines 0 comments Download
M media/base/android/audio_decoder_job.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 6 chunks +140 lines, -4 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 1 chunk +0 lines, -231 lines 0 comments Download
M media/base/android/media_codec_audio_decoder.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
M media/base/android/media_codec_bridge.h View 1 6 chunks +199 lines, -48 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 4 chunks +837 lines, -10 lines 0 comments Download
A media/base/android/media_codec_bridge_unittest.cc View 1 chunk +319 lines, -0 lines 0 comments Download
M media/base/android/media_codec_decoder.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/base/android/media_codec_decoder_unittest.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M media/base/android/media_codec_player_unittest.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
D media/base/android/media_codec_util.h View 1 chunk +0 lines, -63 lines 0 comments Download
D media/base/android/media_codec_util.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M media/base/android/media_codec_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_decoder_job.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 2 chunks +19 lines, -15 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
D media/base/android/ndk_media_codec_bridge.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
D media/base/android/ndk_media_codec_bridge.cc View 1 1 chunk +0 lines, -234 lines 0 comments Download
D media/base/android/sdk_media_codec_bridge.h View 1 1 chunk +0 lines, -198 lines 0 comments Download
D media/base/android/sdk_media_codec_bridge.cc View 1 1 chunk +0 lines, -643 lines 0 comments Download
D media/base/android/sdk_media_codec_bridge_unittest.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M media/base/android/video_decoder_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 4 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
acleung1
Created Revert of Refactor MediaCodecBridge to add support for NDK APIs
5 years ago (2015-12-14 23:12:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525003002/1
5 years ago (2015-12-14 23:15:11 UTC) #2
commit-bot: I haz the power
Failed to apply patch for media/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-14 23:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525003002/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525003002/290001
5 years ago (2015-12-15 00:18:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:290001)
5 years ago (2015-12-15 00:24:06 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-15 00:24:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04baa92bc02e36182c623632f831c1b3411e8434
Cr-Commit-Position: refs/heads/master@{#365131}

Powered by Google App Engine
This is Rietveld 408576698