Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1524893002: Fix imports within the analyzer package (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1744 lines, -1543 lines) Patch
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/dart/element/type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 6 chunks +14 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_handle.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 41 chunks +89 lines, -51 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 20 chunks +79 lines, -54 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 18 chunks +63 lines, -36 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 6 chunks +16 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 12 chunks +911 lines, -912 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/info.dart View 10 chunks +13 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 6 chunks +88 lines, -85 lines 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/enum_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 17 chunks +51 lines, -36 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 5 chunks +12 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 11 chunks +26 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 23 chunks +72 lines, -56 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +21 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 10 chunks +34 lines, -31 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 4 chunks +23 lines, -15 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +59 lines, -57 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 5 chunks +97 lines, -95 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
There are no changes (outside of sorting / formatting noise) except for import declarations.
5 years ago (2015-12-14 19:45:41 UTC) #2
scheglov
LGTM
5 years ago (2015-12-14 20:00:08 UTC) #3
Paul Berry
lgtm
5 years ago (2015-12-14 20:11:34 UTC) #4
Brian Wilkerson
5 years ago (2015-12-14 20:25:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2a190aa11aae93b6b85c1e0f826b8367ba02b255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698