| Index: pkg/analyzer/lib/src/generated/resolver.dart
|
| diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
|
| index 03452f455ec2b47fcbcc0f9c158324328b71f2b8..7c3433d5d18ec5f3c2bfe55be18287c8310b3a6e 100644
|
| --- a/pkg/analyzer/lib/src/generated/resolver.dart
|
| +++ b/pkg/analyzer/lib/src/generated/resolver.dart
|
| @@ -6,9 +6,14 @@ library analyzer.src.generated.resolver;
|
|
|
| import 'dart:collection';
|
|
|
| +import 'package:analyzer/dart/element/element.dart';
|
| +import 'package:analyzer/dart/element/type.dart';
|
| +import 'package:analyzer/dart/element/visitor.dart';
|
| +import 'package:analyzer/src/dart/element/element.dart';
|
| +import 'package:analyzer/src/dart/element/member.dart';
|
| +import 'package:analyzer/src/dart/element/type.dart';
|
| import 'package:analyzer/src/generated/ast.dart';
|
| import 'package:analyzer/src/generated/constant.dart';
|
| -import 'package:analyzer/src/generated/element.dart';
|
| import 'package:analyzer/src/generated/element_resolver.dart';
|
| import 'package:analyzer/src/generated/engine.dart';
|
| import 'package:analyzer/src/generated/error.dart';
|
| @@ -20,7 +25,8 @@ import 'package:analyzer/src/generated/source.dart';
|
| import 'package:analyzer/src/generated/static_type_analyzer.dart';
|
| import 'package:analyzer/src/generated/type_system.dart';
|
| import 'package:analyzer/src/generated/utilities_dart.dart';
|
| -import 'package:analyzer/src/task/strong/info.dart' show InferredType, StaticInfo;
|
| +import 'package:analyzer/src/task/strong/info.dart'
|
| + show InferredType, StaticInfo;
|
|
|
| export 'package:analyzer/src/generated/type_system.dart';
|
|
|
| @@ -1133,8 +1139,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| result =
|
| _validate(element, CompileTimeErrorCode.NON_CONSTANT_LIST_ELEMENT);
|
| if (result != null) {
|
| - _reportErrorIfFromDeferredLibrary(element,
|
| - CompileTimeErrorCode.NON_CONSTANT_LIST_ELEMENT_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + element,
|
| + CompileTimeErrorCode
|
| + .NON_CONSTANT_LIST_ELEMENT_FROM_DEFERRED_LIBRARY);
|
| }
|
| }
|
| }
|
| @@ -1157,8 +1165,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| DartObjectImpl valueResult = _validate(
|
| valueExpression, CompileTimeErrorCode.NON_CONSTANT_MAP_VALUE);
|
| if (valueResult != null) {
|
| - _reportErrorIfFromDeferredLibrary(valueExpression,
|
| - CompileTimeErrorCode.NON_CONSTANT_MAP_VALUE_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + valueExpression,
|
| + CompileTimeErrorCode
|
| + .NON_CONSTANT_MAP_VALUE_FROM_DEFERRED_LIBRARY);
|
| }
|
| if (keyResult != null) {
|
| _reportErrorIfFromDeferredLibrary(key,
|
| @@ -1171,7 +1181,8 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| DartType type = keyResult.type;
|
| if (_implementsEqualsWhenNotAllowed(type)) {
|
| _errorReporter.reportErrorForNode(
|
| - CompileTimeErrorCode.CONST_MAP_KEY_EXPRESSION_TYPE_IMPLEMENTS_EQUALS,
|
| + CompileTimeErrorCode
|
| + .CONST_MAP_KEY_EXPRESSION_TYPE_IMPLEMENTS_EQUALS,
|
| key,
|
| [type.displayName]);
|
| }
|
| @@ -1228,8 +1239,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| DartObjectImpl caseResult = _validate(
|
| expression, CompileTimeErrorCode.NON_CONSTANT_CASE_EXPRESSION);
|
| if (caseResult != null) {
|
| - _reportErrorIfFromDeferredLibrary(expression,
|
| - CompileTimeErrorCode.NON_CONSTANT_CASE_EXPRESSION_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + expression,
|
| + CompileTimeErrorCode
|
| + .NON_CONSTANT_CASE_EXPRESSION_FROM_DEFERRED_LIBRARY);
|
| DartObject value = caseResult;
|
| if (firstType == null) {
|
| firstType = value.type;
|
| @@ -1269,8 +1282,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| }
|
| _reportErrors(result.errors,
|
| CompileTimeErrorCode.CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE);
|
| - _reportErrorIfFromDeferredLibrary(initializer,
|
| - CompileTimeErrorCode.CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + initializer,
|
| + CompileTimeErrorCode
|
| + .CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE_FROM_DEFERRED_LIBRARY);
|
| }
|
| return null;
|
| }
|
| @@ -1363,10 +1378,14 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| identical(dataErrorCode, CompileTimeErrorCode.CONST_EVAL_TYPE_NUM) ||
|
| identical(dataErrorCode,
|
| CompileTimeErrorCode.RECURSIVE_COMPILE_TIME_CONSTANT) ||
|
| - identical(dataErrorCode,
|
| - CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH) ||
|
| - identical(dataErrorCode,
|
| - CheckedModeCompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH) ||
|
| + identical(
|
| + dataErrorCode,
|
| + CheckedModeCompileTimeErrorCode
|
| + .CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH) ||
|
| + identical(
|
| + dataErrorCode,
|
| + CheckedModeCompileTimeErrorCode
|
| + .CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH) ||
|
| identical(dataErrorCode,
|
| CheckedModeCompileTimeErrorCode.VARIABLE_TYPE_MISMATCH)) {
|
| _errorReporter.reportError(data);
|
| @@ -1463,8 +1482,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| result = _validate(
|
| defaultValue, CompileTimeErrorCode.NON_CONSTANT_DEFAULT_VALUE);
|
| if (result != null) {
|
| - _reportErrorIfFromDeferredLibrary(defaultValue,
|
| - CompileTimeErrorCode.NON_CONSTANT_DEFAULT_VALUE_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + defaultValue,
|
| + CompileTimeErrorCode
|
| + .NON_CONSTANT_DEFAULT_VALUE_FROM_DEFERRED_LIBRARY);
|
| }
|
| }
|
| VariableElementImpl element = parameter.element as VariableElementImpl;
|
| @@ -1504,7 +1525,8 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| subErrorReporter));
|
| if (result == null) {
|
| _errorReporter.reportErrorForNode(
|
| - CompileTimeErrorCode.CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST,
|
| + CompileTimeErrorCode
|
| + .CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST,
|
| errorSite,
|
| [variableDeclaration.name.name]);
|
| }
|
| @@ -1534,8 +1556,10 @@ class ConstantVerifier extends RecursiveAstVisitor<Object> {
|
| _reportErrors(errorListener.errors,
|
| CompileTimeErrorCode.NON_CONSTANT_VALUE_IN_INITIALIZER);
|
| if (result != null) {
|
| - _reportErrorIfFromDeferredLibrary(expression,
|
| - CompileTimeErrorCode.NON_CONSTANT_VALUE_IN_INITIALIZER_FROM_DEFERRED_LIBRARY);
|
| + _reportErrorIfFromDeferredLibrary(
|
| + expression,
|
| + CompileTimeErrorCode
|
| + .NON_CONSTANT_VALUE_IN_INITIALIZER_FROM_DEFERRED_LIBRARY);
|
| }
|
| }
|
|
|
| @@ -5673,8 +5697,9 @@ class InheritanceManager {
|
| if (memberName == null || memberName.isEmpty) {
|
| return null;
|
| }
|
| - ExecutableElement executable = _computeClassChainLookupMap(
|
| - classElt, new HashSet<ClassElement>()).get(memberName);
|
| + ExecutableElement executable =
|
| + _computeClassChainLookupMap(classElt, new HashSet<ClassElement>())
|
| + .get(memberName);
|
| if (executable == null) {
|
| return _computeInterfaceLookupMap(classElt, new HashSet<ClassElement>())
|
| .get(memberName);
|
| @@ -6329,8 +6354,9 @@ class InheritanceManager {
|
| // Tests: test_getMapOfMembersInheritedFromInterfaces_
|
| // union_multipleSubtypes_*
|
| //
|
| - List<ExecutableElement> elementArrayToMerge = new List<
|
| - ExecutableElement>(subtypesOfAllOtherTypesIndexes.length);
|
| + List<ExecutableElement> elementArrayToMerge =
|
| + new List<ExecutableElement>(
|
| + subtypesOfAllOtherTypesIndexes.length);
|
| for (int i = 0; i < elementArrayToMerge.length; i++) {
|
| elementArrayToMerge[i] =
|
| elements[subtypesOfAllOtherTypesIndexes[i]];
|
| @@ -6345,7 +6371,8 @@ class InheritanceManager {
|
| classElt,
|
| classElt.nameOffset,
|
| classElt.nameLength,
|
| - StaticWarningCode.INCONSISTENT_METHOD_INHERITANCE_GETTER_AND_METHOD,
|
| + StaticWarningCode
|
| + .INCONSISTENT_METHOD_INHERITANCE_GETTER_AND_METHOD,
|
| [key]);
|
| }
|
| }
|
| @@ -6492,8 +6519,8 @@ class InheritanceManager {
|
| int numOfPositionalParameters,
|
| List<String> namedParameters) {
|
| DynamicTypeImpl dynamicType = DynamicTypeImpl.instance;
|
| - SimpleIdentifier nameIdentifier = new SimpleIdentifier(
|
| - new StringToken(TokenType.IDENTIFIER, name, 0));
|
| + SimpleIdentifier nameIdentifier =
|
| + new SimpleIdentifier(new StringToken(TokenType.IDENTIFIER, name, 0));
|
| ExecutableElementImpl executable;
|
| if (elementArrayToMerge[0] is MethodElement) {
|
| MultiplyInheritedMethodElementImpl unionedMethod =
|
| @@ -6582,7 +6609,7 @@ class InheritanceManager {
|
| static int _getNumOfPositionalParameters(
|
| ExecutableElement executableElement) =>
|
| _getNumOfParameters(executableElement, ParameterKind.REQUIRED) +
|
| - _getNumOfParameters(executableElement, ParameterKind.POSITIONAL);
|
| + _getNumOfParameters(executableElement, ParameterKind.POSITIONAL);
|
|
|
| /**
|
| * Given some [ExecutableElement] return the number of required parameters.
|
| @@ -12132,10 +12159,10 @@ class TypeResolverVisitor extends ScopedVisitor {
|
| } else if ((redirectingConstructorKind =
|
| _getRedirectingConstructorKind(node)) !=
|
| null) {
|
| - ErrorCode errorCode = (redirectingConstructorKind ==
|
| - RedirectingConstructorKind.CONST
|
| - ? CompileTimeErrorCode.REDIRECT_TO_NON_CLASS
|
| - : StaticWarningCode.REDIRECT_TO_NON_CLASS);
|
| + ErrorCode errorCode =
|
| + (redirectingConstructorKind == RedirectingConstructorKind.CONST
|
| + ? CompileTimeErrorCode.REDIRECT_TO_NON_CLASS
|
| + : StaticWarningCode.REDIRECT_TO_NON_CLASS);
|
| reportErrorForNode(errorCode, typeName, [typeName.name]);
|
| } else if (_isTypeNameInTypeArgumentList(node)) {
|
| reportErrorForNode(StaticTypeWarningCode.NON_TYPE_AS_TYPE_ARGUMENT,
|
| @@ -12192,10 +12219,10 @@ class TypeResolverVisitor extends ScopedVisitor {
|
| } else if ((redirectingConstructorKind =
|
| _getRedirectingConstructorKind(node)) !=
|
| null) {
|
| - ErrorCode errorCode = (redirectingConstructorKind ==
|
| - RedirectingConstructorKind.CONST
|
| - ? CompileTimeErrorCode.REDIRECT_TO_NON_CLASS
|
| - : StaticWarningCode.REDIRECT_TO_NON_CLASS);
|
| + ErrorCode errorCode =
|
| + (redirectingConstructorKind == RedirectingConstructorKind.CONST
|
| + ? CompileTimeErrorCode.REDIRECT_TO_NON_CLASS
|
| + : StaticWarningCode.REDIRECT_TO_NON_CLASS);
|
| reportErrorForNode(errorCode, typeName, [typeName.name]);
|
| } else if (_isTypeNameInTypeArgumentList(node)) {
|
| reportErrorForNode(StaticTypeWarningCode.NON_TYPE_AS_TYPE_ARGUMENT,
|
|
|