Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 1523953004: Fix volume slider to emit value changed events and do not focus system tray item for transient views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/system/tray/system_tray.cc ('K') | « ash/system/tray/system_tray.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
index 8f20f28be389e6e3d2b07a8db823e0733e3c3955..306c739f82e9593db9d0add0eb8fd5fe02d5e7c1 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
@@ -237,15 +237,12 @@ DesktopAutomationHandler.prototype = {
ChromeVoxState.instance.mode === ChromeVoxMode.CLASSIC)
return;
- if (!evt.target.state.focused)
- return;
-
// Value change events fire on web editables when typing. Suppress them.
if (!ChromeVoxState.instance.currentRange ||
!this.isEditable_(evt.target)) {
- this.onEventDefault(evt);
- ChromeVoxState.instance.setCurrentRange(
- cursors.Range.fromNode(evt.target));
+ var range = cursors.Range.fromNode(evt.target);
+ new Output().withSpeechAndBraille(range, range, evt.type)
+ .go();
}
},
« ash/system/tray/system_tray.cc ('K') | « ash/system/tray/system_tray.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698