ash/system/tray/system_tray.cc - Issue 1523953004: Fix volume slider to emit value changed events and do not focus system tray item for transient views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/tray/system_tray.cc

Issue 1523953004: Fix volume slider to emit value changed events and do not focus system tray item for transient views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/audio/volume_view.cc ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/tray/system_tray.cc

diff --git a/ash/system/tray/system_tray.cc b/ash/system/tray/system_tray.cc

index 715c7afa7aae85c1acf8096dd12a60ea9115d743..2cdb6da573b9538c5186615add65af5e44507a41 100644

--- a/ash/system/tray/system_tray.cc

+++ b/ash/system/tray/system_tray.cc

@@ -99,8 +99,10 @@ class SystemBubbleWrapper {

is_persistent_ = is_persistent;

// If ChromeVox is enabled, focus the default item if no item is focused.

- if (Shell::GetInstance()->accessibility_delegate()->

- IsSpokenFeedbackEnabled()) {

+ if (Shell::GetInstance()

+ ->accessibility_delegate()

+ ->IsSpokenFeedbackEnabled() &&

+ !is_persistent) {

oshima 2015/12/15 23:52:39 Am I correct that we do not want to set the focus

David Tseng 2015/12/16 16:47:49 That's correct. The semantics are important here.

bubble_->FocusDefaultIfNeeded();

}