[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>;

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f5746542697

Committed: https://chromium.googlesource.com/v8/v8/+/5bd4832492e66b79b19a45653abc68bef3cd6cb4

[Benedikt Meurer, 2015-12-14 13:39:38]

v8-mips-ports: Could you please port this CL to mips/mips64?

[balazs.kilvady, 2015-12-14 14:29:22]

We are working on it.

[Benedikt Meurer, 2015-12-14 14:46:00]

ARM people: Can you add arm64 port?

[Rodolph Perfetta, 2015-12-14 15:48:56]

On 2015/12/14 14:46:00, Benedikt Meurer wrote:
> ARM people: Can you add arm64 port?

We'll have look.

[Benedikt Meurer, 2015-12-15 05:37:51]

bmeurer@chromium.org changed reviewers:
+ yangguo@chromium.org

[Benedikt Meurer, 2015-12-15 05:37:52]

Hey Yang,

This removes 3 of the 4 last weird JS builtins, and optimizes
Reflect.apply/construct and Function.prototype.apply for the most common cases
(we could even add fast support for holey JSArrays later if necessary).
Please take a look (mips/mips64/arm64 ports are done added by partners).

Thanks,
Benedikt

[Yang, 2015-12-15 06:06:49]

On 2015/12/15 05:37:52, Benedikt Meurer wrote:
> Hey Yang,
> 
> This removes 3 of the 4 last weird JS builtins, and optimizes
> Reflect.apply/construct and Function.prototype.apply for the most common cases
> (we could even add fast support for holey JSArrays later if necessary).
> Please take a look (mips/mips64/arm64 ports are done added by partners).
> 
> Thanks,
> Benedikt

LGTM. I only looked at the ARM port though.

[Yang, 2015-12-15 06:06:58]

https://codereview.chromium.org/1523753002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1523753002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:1870: native_context->set_reflect_apply(*apply);
You can move this to InitializeGlobal if you rebase onto
https://codereview.chromium.org/1515133002/diff/80001/src/bootstrapper.cc to use
CreateFunction. You corrected noted that we don't need to install those
functions on the export container since the %-syntax also works.

But maybe do it in a separate CL.

[Benedikt Meurer, 2015-12-15 06:08:28]

https://codereview.chromium.org/1523753002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1523753002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:1870: native_context->set_reflect_apply(*apply);
Yes, my plan was to further simplify this stuff later, ideally after
CONCAT_ITERABLE_TO_ARRAY also disappeared.

[paul.l..., 2015-12-16 01:03:41]

paul.lind@imgtec.com changed reviewers:
+ paul.lind@imgtec.com

[paul.l..., 2015-12-16 01:03:41]

Benedikt, please find MIPS ports in https://codereview.chromium.org/1526253002

[Benedikt Meurer, 2015-12-16 04:50:31]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

BUG=v8:4413, v8:4430
LOG=n
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

BUG=v8:4413, v8:4430
LOG=n
==========

[Benedikt Meurer, 2015-12-16 04:50:47]

Thanks Paul and Balaz.

[Benedikt Meurer, 2015-12-17 06:23:24]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

BUG=v8:4413, v8:4430
LOG=n
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
==========

[Benedikt Meurer, 2015-12-17 06:31:27]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 06:31:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523753002/80001

[Benedikt Meurer, 2015-12-17 07:46:44]

The CQ bit was unchecked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-17 07:47:49]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed: https://crrev.com/e4d2538911f6cb4b626830ccbb3c1f5746542697
Cr-Commit-Position: refs/heads/master@{#32927}
==========

[Benedikt Meurer, 2015-12-17 07:47:50]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed: https://crrev.com/e4d2538911f6cb4b626830ccbb3c1f5746542697
Cr-Commit-Position: refs/heads/master@{#32927}
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

[commit-bot: I haz the power, 2015-12-17 07:47:50]

Patchset 5 (id:??) landed as
https://crrev.com/e4d2538911f6cb4b626830ccbb3c1f5746542697
Cr-Commit-Position: refs/heads/master@{#32927}

[Benedikt Meurer, 2015-12-17 07:47:53]

Committed patchset #5 (id:80001) manually as
e4d2538911f6cb4b626830ccbb3c1f5746542697 (presubmit successful).

[Benedikt Meurer, 2015-12-17 08:05:28]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1533803002/ by bmeurer@chromium.org.

The reason for reverting is: Breaks TSAN somewhow:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7000.

[Benedikt Meurer, 2015-12-17 08:09:14]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

[Benedikt Meurer, 2015-12-17 08:10:15]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

[Benedikt Meurer, 2015-12-17 08:10:23]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[Benedikt Meurer, 2015-12-17 08:13:15]

The CQ bit was unchecked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-17 08:41:24]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...

Committed: https://crrev.com/5bd4832492e66b79b19a45653abc68bef3cd6cb4
Cr-Commit-Position: refs/heads/master@{#32929}
==========

[commit-bot: I haz the power, 2015-12-17 08:41:25]

Patchset 6 (id:??) landed as
https://crrev.com/5bd4832492e66b79b19a45653abc68bef3cd6cb4
Cr-Commit-Position: refs/heads/master@{#32929}

[Benedikt Meurer, 2015-12-17 08:41:28]

Description was changed from

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...

Committed: https://crrev.com/5bd4832492e66b79b19a45653abc68bef3cd6cb4
Cr-Commit-Position: refs/heads/master@{#32929}
==========

to

==========
[es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply.

Introduce a new Apply builtin that forms a correct and optimizable
foundation for the Function.prototype.apply, Reflect.construct and
Reflect.apply builtins (which properly does the PrepareForTailCall
as required by the ES2015 spec).

The new Apply builtin avoids going to the runtime if it is safe to
just access the backing store elements of the argArray, i.e. if you
pass a JSArray with no holes, or an unmapped, unmodified sloppy or
strict arguments object.

mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com>

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
BUG=v8:4413, v8:4430
LOG=n
R=yangguo@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f57465...

Committed:
https://chromium.googlesource.com/v8/v8/+/5bd4832492e66b79b19a45653abc68bef3c...
==========

[Benedikt Meurer, 2015-12-17 08:41:30]

Committed patchset #6 (id:100001) manually as
5bd4832492e66b79b19a45653abc68bef3cd6cb4 (presubmit successful).

[Michael Achenbach, 2016-02-04 10:49:00]

On 2015/12/17 08:41:30, Benedikt Meurer wrote:
> Committed patchset #6 (id:100001) manually as
> 5bd4832492e66b79b19a45653abc68bef3cd6cb4 (presubmit successful).

Note that this makes the test mjsunit/apply a lot (100X) slower in stress mode.
Could you make that test faster again? Otherwise we need a skip.