Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1526253002: MIPS: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. (Closed)

Created:
5 years ago by paul.l...
Modified:
5 years ago
Reviewers:
Benedikt Meurer, v8-mips-ports, balazs.kilvady
CC:
v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. Port for https://codereview.chromium.org/1523753002/ Original commit message: Introduce a new Apply builtin that forms a correct and optimizable foundation for the Function.prototype.apply, Reflect.construct and Reflect.apply builtins (which properly does the PrepareForTailCall as required by the ES2015 spec). The new Apply builtin avoids going to the runtime if it is safe to just access the backing store elements of the argArray, i.e. if you pass a JSArray with no holes, or an unmapped, unmodified sloppy or strict arguments object. BUG=v8:4413, v8:4430 LOG=n patch from issue 1530713003 at patchset 1 (http://crrev.com/1530713003#ps1)

Patch Set 1 : Original port from Balázs #

Patch Set 2 : minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -318 lines) Patch
M src/mips/builtins-mips.cc View 1 3 chunks +312 lines, -159 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 chunks +311 lines, -159 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
paul.l...
l-g-t-m for inclusion in https://codereview.chromium.org/1523753002/
5 years ago (2015-12-16 01:08:11 UTC) #2
Benedikt Meurer
5 years ago (2015-12-16 04:51:05 UTC) #4
Thanks a lot guys!

Powered by Google App Engine
This is Rietveld 408576698