Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1523463004: Restore TextCaseSensitivity argument to literal {start,end}sWith (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore TextCaseSensitivity argument to literal {start,end}sWith This reverts the change made by: https://codereview.chromium.org/1507763003 hence restoring the method signatures. Implementations are adjusted based on intermediate changes, like supporting ASCII case-insensitive. Reorganize the equalSubstring* helpers so that more code can be shared (at least textually.) Also try to make the naming of arguments consistent for the various startsWith/endsWith implementations ("prefix"/"suffix" rather than "match"). BUG=568584 Committed: https://crrev.com/00941c49989c1ede7f6bee055f1c03c12bc1d13d Cr-Commit-Position: refs/heads/master@{#364957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -57 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 11 chunks +76 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fs
Appears I was a bit too eager (and blind) when removing these. Restored thusly. PTAL.
5 years ago (2015-12-12 14:22:47 UTC) #4
tkent
lgtm
5 years ago (2015-12-13 23:35:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523463004/1
5 years ago (2015-12-13 23:35:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 03:25:33 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-14 03:27:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00941c49989c1ede7f6bee055f1c03c12bc1d13d
Cr-Commit-Position: refs/heads/master@{#364957}

Powered by Google App Engine
This is Rietveld 408576698