Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1507763003: Drop TextCaseSensitivity from {start,end}sWith(const char*, ...) (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop TextCaseSensitivity from {start,end}sWith(const char*, ...) The only user that's uses case-insensitive matching is localeIdMatchesLang(), which can get a helper of its own (broken out of equalInner). Also rearrange/rewrite localeIdMatchesLang() a bit to not compare the language prefix again for each possible delimiter, and skip the "full" comparison at the start (using a prefix match+length check instead.) Also remove the templated StringImpl::{start,end}sWith. BUG=565878 Committed: https://crrev.com/671aee126162122a3607eb2d5be89f244de22554 Cr-Commit-Position: refs/heads/master@{#364014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -40 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 4 chunks +23 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507763003/1
5 years ago (2015-12-08 21:51:24 UTC) #2
fs
This is the first part of https://codereview.chromium.org/1499933003 (see that for more context) - two more ...
5 years ago (2015-12-08 22:47:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-08 23:32:00 UTC) #6
tkent
lgtm
5 years ago (2015-12-09 01:17:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507763003/1
5 years ago (2015-12-09 08:45:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 08:55:30 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-09 08:57:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/671aee126162122a3607eb2d5be89f244de22554
Cr-Commit-Position: refs/heads/master@{#364014}

Powered by Google App Engine
This is Rietveld 408576698