Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1523403004: Minor cleanup of CrSettingsBrowserTest (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
Reviewers:
dschuyler, michaelpg, dpapad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup of CrSettingsBrowserTest Mostly this ensures that PolymerTest.prototype.setUp gets called so that iron-test-helpers is available and navigation works as expected. BUG=425627 Committed: https://crrev.com/c489cfe41358bd70279f34d04d6a5252f02eb03d Cr-Commit-Position: refs/heads/master@{#365703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/test/data/webui/settings/settings_page_browsertest.js View 3 chunks +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
stevenjb
5 years ago (2015-12-16 20:43:43 UTC) #2
dpapad
lgtm
5 years ago (2015-12-16 21:21:15 UTC) #3
dschuyler
lgtm
5 years ago (2015-12-16 22:28:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523403004/1
5 years ago (2015-12-16 22:33:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 03:18:11 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-17 03:20:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c489cfe41358bd70279f34d04d6a5252f02eb03d
Cr-Commit-Position: refs/heads/master@{#365703}

Powered by Google App Engine
This is Rietveld 408576698