Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4096)

Unified Diff: chrome/test/data/webui/settings/settings_page_browsertest.js

Issue 1523403004: Minor cleanup of CrSettingsBrowserTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_page_browsertest.js b/chrome/test/data/webui/settings/settings_page_browsertest.js
index 22c7c8e29d980a5570cb0b89bc74a1d151fd9fba..dfefb889ae61cdf41d2a3c0ed00f0339ba32056a 100644
--- a/chrome/test/data/webui/settings/settings_page_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_page_browsertest.js
@@ -31,6 +31,7 @@ SettingsPageBrowserTest.prototype = {
/** @override */
setUp: function() {
+ PolymerTest.prototype.setUp.call(this);
suiteSetup(function() {
return CrSettingsPrefs.initialized;
});
@@ -38,14 +39,14 @@ SettingsPageBrowserTest.prototype = {
/**
* @param {string} type The settings page type, e.g. 'advanced' or 'basic'.
- * @return {Node} The DOM node for the page.
+ * @return {!PolymerElement} The PolymerElement for the page.
*/
getPage: function(type) {
var settings = document.querySelector('cr-settings');
assertTrue(!!settings);
- var settingsUi = settings.shadowRoot.querySelector('settings-ui');
+ var settingsUi = settings.$$('settings-ui');
assertTrue(!!settingsUi);
- var settingsMain = settingsUi.shadowRoot.querySelector('settings-main');
+ var settingsMain = settingsUi.$$('settings-main');
assertTrue(!!settingsMain);
var pages = settingsMain.$.pageContainer;
assertTrue(!!pages);
@@ -56,7 +57,8 @@ SettingsPageBrowserTest.prototype = {
},
/**
- * @param {Node} page The DOM node for the settings page containing |section|.
+ * @param {!PolymerElement} page The PolymerElement for the page containing
+ * |section|.
* @param {string} section The settings page section, e.g. 'appearance'.
* @return {Node|undefined} The DOM node for the section.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698