Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart

Issue 1523163004: rename InheritedContributor to OverrideContributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart
deleted file mode 100644
index d60076b642ec2cc12ff5de1d28768f0002729415..0000000000000000000000000000000000000000
--- a/pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart
+++ /dev/null
@@ -1,152 +0,0 @@
-// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library services.completion.dart.invocation;
-
-import 'dart:async';
-
-import 'package:analysis_server/src/protocol_server.dart'
- show CompletionSuggestion, CompletionSuggestionKind, SourceChange;
-import 'package:analysis_server/src/protocol_server.dart' as protocol
- hide CompletionSuggestion, CompletionSuggestionKind;
-import 'package:analysis_server/src/provisional/completion/completion_core.dart';
-import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
-import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';
-import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/src/generated/ast.dart';
-import 'package:analyzer/src/generated/resolver.dart';
-import 'package:analyzer/src/generated/source.dart';
-
-/**
- * A completion contributor used to suggest replacing partial identifiers inside
- * a class declaration with templates for inherited members.
- */
-class InheritedContributor implements DartCompletionContributor {
- @override
- Future<List<CompletionSuggestion>> computeSuggestions(
- DartCompletionRequest request) async {
- SimpleIdentifier targetId = _getTargetId(request.target);
- if (targetId == null) {
- return EMPTY_LIST;
- }
- ClassDeclaration classDecl =
- targetId.getAncestor((p) => p is ClassDeclaration);
- if (classDecl == null) {
- return EMPTY_LIST;
- }
-
- // Generate a collection of inherited members
- ClassElement classElem = classDecl.element;
- InheritanceManager manager = new InheritanceManager(classElem.library);
- MemberMap map = manager.getMapOfMembersInheritedFromInterfaces(classElem);
- List<String> memberNames = _computeMemberNames(map, classElem);
-
- // Build suggestions
- List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];
- for (String memberName in memberNames) {
- ExecutableElement element = map.get(memberName);
- // Gracefully degrade if the overridden element has not been resolved.
- if (element.returnType != null) {
- CompletionSuggestion suggestion =
- _buildSuggestion(request, targetId, element);
- if (suggestion != null) {
- suggestions.add(suggestion);
- }
- }
- }
- return suggestions;
- }
-
- /**
- * Return a template for an override of the given [element] in the given
- * [source]. If selected, the template will replace [targetId].
- */
- String _buildRepacementText(Source source, SimpleIdentifier targetId,
- CompilationUnit unit, ExecutableElement element) {
- // AnalysisContext context = element.context;
- // Inject partially resolved unit for use by change builder
- // DartChangeBuilder builder = new DartChangeBuilder(context, unit);
- // builder.addFileEdit(source, context.getModificationStamp(source),
- // (DartFileEditBuilder builder) {
- // builder.addReplacement(targetId.offset, targetId.length,
- // (DartEditBuilder builder) {
- // builder.writeOverrideOfInheritedMember(element);
- // });
- // });
- // return builder.sourceChange.edits[0].edits[0].replacement.trim();
- return '';
- }
-
- /**
- * Build a suggestion to replace [targetId] in the given [unit]
- * with an override of the given [element].
- */
- CompletionSuggestion _buildSuggestion(DartCompletionRequest request,
- SimpleIdentifier targetId, ExecutableElement element) {
- String completion = _buildRepacementText(
- request.source, targetId, request.target.unit, element);
- if (completion == null || completion.length == 0) {
- return null;
- }
- CompletionSuggestion suggestion = new CompletionSuggestion(
- CompletionSuggestionKind.IDENTIFIER,
- DART_RELEVANCE_HIGH,
- completion,
- targetId.offset,
- 0,
- element.isDeprecated,
- false);
- suggestion.element = protocol.convertElement(element);
- return suggestion;
- }
-
- /**
- * Return a list containing the names of all of the inherited but not
- * implemented members of the class represented by the given [element].
- * The [map] is used to find all of the members that are inherited.
- */
- List<String> _computeMemberNames(MemberMap map, ClassElement element) {
- List<String> memberNames = <String>[];
- int count = map.size;
- for (int i = 0; i < count; i++) {
- String memberName = map.getKey(i);
- if (!_hasMember(element, memberName)) {
- memberNames.add(memberName);
- }
- }
- return memberNames;
- }
-
- /**
- * If the target looks like a partial identifier inside a class declaration
- * then return that identifier, otherwise return `null`.
- */
- SimpleIdentifier _getTargetId(CompletionTarget target) {
- AstNode node = target.containingNode;
- if (node is ClassDeclaration) {
- Object entity = target.entity;
- if (entity is FieldDeclaration) {
- NodeList<VariableDeclaration> variables = entity.fields.variables;
- if (variables.length == 1) {
- SimpleIdentifier targetId = variables[0].name;
- if (targetId.name.isEmpty) {
- return targetId;
- }
- }
- }
- }
- return null;
- }
-
- /**
- * Return `true` if the given [classElement] directly declares a member with
- * the given [memberName].
- */
- bool _hasMember(ClassElement classElement, String memberName) {
- return classElement.getField(memberName) != null ||
- classElement.getGetter(memberName) != null ||
- classElement.getMethod(memberName) != null ||
- classElement.getSetter(memberName) != null;
- }
-}

Powered by Google App Engine
This is Rietveld 408576698