pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart - Issue 1523163004: rename InheritedContributor to OverrideContributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

Issue 1523163004: rename InheritedContributor to OverrideContributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

diff --git a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

index 805d8377ffbfb8094748db13ea9f806a6ee28b83..f36dd7207c77052a5cd879235bf549a1bd613406 100644

--- a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

+++ b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart

@@ -99,6 +99,10 @@ class DartCompletionPlugin implements Plugin {

() => new LocalReferenceContributor());

registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,

() => new NamedConstructorContributor());

+ // Revisit this contributor and these tests

+ // once DartChangeBuilder API has solidified.

+ // registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,

+ // () => new OverrideContributor());

registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,

() => new StaticMemberContributor());

registerExtension(DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart » ('j') | no next file with comments »