Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1523093003: Move summary references into UnlinkedUnit and PrelinkedUnit. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move summary references into UnlinkedUnit and PrelinkedUnit. This is a follow up to commit f85684604b28449cb5946ed855983678f69e432f, which reorganized the declarations by compilation unit to pave the way for allowing summaries to be "re-linked" if the relationship between part files changes. Organizing references by compilation unit is another necessary step to make that possible. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/518ae623d6ccdc355237dd97d6b19fc4d5fcb0e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -70 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 15 chunks +31 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 10 chunks +44 lines, -12 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 6 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
5 years ago (2015-12-15 18:01:44 UTC) #2
scheglov
LGTM
5 years ago (2015-12-15 18:46:25 UTC) #3
Paul Berry
5 years ago (2015-12-15 18:55:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
518ae623d6ccdc355237dd97d6b19fc4d5fcb0e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698