Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1523093003: Move summary references into UnlinkedUnit and PrelinkedUnit. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/idl.dart
diff --git a/pkg/analyzer/tool/summary/idl.dart b/pkg/analyzer/tool/summary/idl.dart
index 65b319c3f359f8909c362336fa2dd032939f95ee..ff44090ece6916823f3b33ab38bd27c0d70f7b07 100644
--- a/pkg/analyzer/tool/summary/idl.dart
+++ b/pkg/analyzer/tool/summary/idl.dart
@@ -110,12 +110,6 @@ class PrelinkedLibrary {
* well, since there will effectively be a one-to-one mapping.
*/
List<int> importDependencies;
-
- /**
- * For each reference in [UnlinkedLibrary.references], information about how
- * that reference is resolved.
- */
- List<PrelinkedReference> references;
}
/**
@@ -177,6 +171,12 @@ class PrelinkedUnit {
* The unlinked summary of the compilation unit
*/
UnlinkedUnit unlinked;
+
+ /**
+ * For each reference in [UnlinkedUnit.references], information about how
+ * that reference is resolved.
+ */
+ List<PrelinkedReference> references;
}
/**
@@ -438,11 +438,6 @@ class UnlinkedImport {
*/
class UnlinkedLibrary {
/**
- * Top level and prefixed names referred to by this library.
- */
- List<UnlinkedReference> references;
-
- /**
* Prefixes introduced by import declarations. The first element in this
* array is a pseudo-prefix used by references made with no prefix.
*/
@@ -597,11 +592,11 @@ class UnlinkedTypeParam {
*/
class UnlinkedTypeRef {
/**
- * Index into [UnlinkedLibrary.references] for the type being referred to, or
+ * Index into [UnlinkedUnit.references] for the type being referred to, or
* zero if this is a reference to a type parameter.
*
* Note that since zero is also a valid index into
- * [UnlinkedLibrary.references], we cannot distinguish between references to
+ * [UnlinkedUnit.references], we cannot distinguish between references to
* type parameters and references to types by checking [reference] against
* zero. To distinguish between references to type parameters and references
* to types, check whether [paramReference] is zero.
@@ -637,11 +632,7 @@ class UnlinkedTypeRef {
}
/**
- * Unlinked summary information about a compilation unit ("part file"). Note
- * that since a declaration can be moved from one part file to another without
- * changing semantics, the declarations themselves aren't stored here; they are
- * stored in [UnlinkedLibrary] and they refer to [UnlinkedUnit]s via an index
- * into [UnlinkedLibrary.units].
+ * Unlinked summary information about a compilation unit ("part file").
*/
class UnlinkedUnit {
/**
@@ -650,6 +641,11 @@ class UnlinkedUnit {
String libraryName;
/**
+ * Top level and prefixed names referred to by this compilation unit.
+ */
+ List<UnlinkedReference> references;
+
+ /**
* Classes declared in the compilation unit.
*/
List<UnlinkedClass> classes;
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698