Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace

Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace (patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/3417/steps/memory%20test%3A%20unit/logs/stdio

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB 12-00>)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)] Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318): error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284): error: Actual function call count doesn't match EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
>
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
>
> BUG=57884
> R=zea@chromium.org
>
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884
Committed: https://crrev.com/ad98c9c23220d90ad556db02b072dcb363e328b7
Cr-Commit-Position: refs/heads/master@{#365123}

[Jeffrey Yasskin, 2015-12-14 21:17:17]

Created Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace

[Jeffrey Yasskin, 2015-12-14 21:19:31]

Description was changed from

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
> 
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
> 
> BUG=57884
> R=zea@chromium.org
> 
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=57884
==========

to

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
> 
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
> 
> BUG=57884
> R=zea@chromium.org
> 
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884
==========

[Jeffrey Yasskin, 2015-12-14 21:19:35]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2015-12-14 21:20:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523083002/1

[commit-bot: I haz the power, 2015-12-14 21:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 21:23:53]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2015-12-14 21:28:04]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2015-12-14 21:30:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523083002/40001

[commit-bot: I haz the power, 2015-12-14 23:15:14]

Description was changed from

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
> 
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
> 
> BUG=57884
> R=zea@chromium.org
> 
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884
==========

to

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
> 
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
> 
> BUG=57884
> R=zea@chromium.org
> 
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884
==========

[commit-bot: I haz the power, 2015-12-14 23:15:14]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-14 23:16:10]

Description was changed from

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
> 
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
> 
> BUG=57884
> R=zea@chromium.org
> 
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884
==========

to

==========
Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
(patchset #1 id:1 of https://codereview.chromium.org/1511333003/ )

Reason for revert:
This is broken on the DrMemory bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[ RUN      ] ProfileSyncServiceAutofillTest.ServerChangeRace

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterDataTypes(@05A1F340 8-byte object <C0-B7 D2-11 0E-BB
12-00>)
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2356:1210/173205:14452494:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2356:1210/173205:14452494:WARNING:sync_encryption_handler_impl.cc(989)]
Nigori had empty encryption keybag.
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(95)] No
history worker -- removing TYPED_URLS
[3560:2436:1210/173205:14452697:WARNING:sync_backend_registrar.cc(99)] No
password worker -- removing PASSWORDS
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1318):
error: Value of: sync_entries.size()
  Actual: 2
Expected: 3U
Which is: 3
c:\b\build\slave\drm-cr\build\src\chrome\browser\sync\profile_sync_service_autofill_unittest.cc(1284):
error: Actual function call count doesn't match
EXPECT_CALL(*personal_data_manager_, Refresh())...
         Expected: to be called 3 times
           Actual: called twice - unsatisfied and active
[  FAILED  ] ProfileSyncServiceAutofillTest.ServerChangeRace (356 ms)

Original issue's description:
> [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace
>
> Test was disabled because number of calls to
> PersonalDataManager::Refresh didn't match expectation. I think this
> happened because calls to Refresh were posted to UI thread, but test
> didn't run message loop at the end of the test.
>
> BUG=57884
> R=zea@chromium.org
>
> Committed: https://crrev.com/14e9197c285a1edc95dc7e2f314f814fcc0a853f
> Cr-Commit-Position: refs/heads/master@{#364439}

TBR=zea@chromium.org,pavely@chromium.org
BUG=57884

Committed: https://crrev.com/ad98c9c23220d90ad556db02b072dcb363e328b7
Cr-Commit-Position: refs/heads/master@{#365123}
==========

[commit-bot: I haz the power, 2015-12-14 23:16:24]

Patchset 2 (id:??) landed as
https://crrev.com/ad98c9c23220d90ad556db02b072dcb363e328b7
Cr-Commit-Position: refs/heads/master@{#365123}