Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 1523083002: Revert of [Sync] Enable ProfileSyncServiceAutofillTest.ServerChangeRace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync past r365021. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index 65a33e8f81b1be11794d9c86ea8d4f79d2286e76..791bfb672aadca31c94ad20707c96fad73b2fb44 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -16,7 +16,7 @@
#include "base/location.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "base/run_loop.h"
+#include "base/message_loop/message_loop.h"
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/waitable_event.h"
@@ -526,9 +526,7 @@ class ProfileSyncServiceAutofillTest
sync_service_->RegisterDataTypeController(CreateDataTypeController(type));
sync_service_->Initialize();
-
- base::RunLoop run_loop;
- run_loop.Run();
+ base::MessageLoop::current()->Run();
// It's possible this test triggered an unrecoverable error, in which case
// we can't get the sync count.
@@ -1268,8 +1266,8 @@ TEST_F(ProfileSyncServiceAutofillTest, ProcessUserChangeRemoveProfile) {
ASSERT_EQ(0U, new_sync_profiles.size());
}
-// crbug.com/569551
-TEST_F(ProfileSyncServiceAutofillTest, FLAKY_ServerChangeRace) {
+// http://crbug.com/57884
+TEST_F(ProfileSyncServiceAutofillTest, DISABLED_ServerChangeRace) {
// Once for MergeDataAndStartSyncing() and twice for ProcessSyncChanges(), via
// LoadAutofillData().
EXPECT_CALL(autofill_table_, GetAllAutofillEntries(_)).
@@ -1306,10 +1304,6 @@ TEST_F(ProfileSyncServiceAutofillTest, FLAKY_ServerChangeRace) {
// to clean up.
updater->CreateNewEntryAndWait(MakeAutofillEntry("server2", "entry2", 3));
- // Let callbacks posted on UI thread execute.
- base::RunLoop run_loop;
- run_loop.RunUntilIdle();
-
std::vector<AutofillEntry> sync_entries;
std::vector<AutofillProfile> sync_profiles;
ASSERT_TRUE(GetAutofillEntriesFromSyncDB(&sync_entries, &sync_profiles));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698