Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1523013002: Fold ApiObjectConverter use into ApiMessageReader (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
turnidge, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fold ApiObjectConverter use into ApiMessageReader TODO from change on Friday. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/fa8a0613a3ef993ae69ffad683c668d45d432306

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M runtime/vm/dart_api_message.h View 1 4 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 2 chunks +28 lines, -6 lines 0 comments Download
M runtime/vm/native_message_handler.cc View 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
5 years ago (2015-12-14 17:15:28 UTC) #2
turnidge
lgtm
5 years ago (2015-12-14 17:59:42 UTC) #3
zra
5 years ago (2015-12-14 19:12:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fa8a0613a3ef993ae69ffad683c668d45d432306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698