Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/vm/native_message_handler.cc

Issue 1523013002: Fold ApiObjectConverter use into ApiMessageReader (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_message_handler.cc
diff --git a/runtime/vm/native_message_handler.cc b/runtime/vm/native_message_handler.cc
index e99caa5debe3ee22d3b456bdebf6d2571faf359e..7779e95c5f369bfac872a4056d0cbb63a67ce29c 100644
--- a/runtime/vm/native_message_handler.cc
+++ b/runtime/vm/native_message_handler.cc
@@ -42,22 +42,10 @@ MessageHandler::MessageStatus NativeMessageHandler::HandleMessage(
// All allocation of objects for decoding the message is done in the
// zone associated with this scope.
ApiNativeScope scope;
-
- if (message->IsRaw()) {
- // TODO(zra): This should be folded into ApiMessageReader. This will likely
- // require ApiMessageReader to have a constructor that takes a Message*.
- ASSERT(ApiObjectConverter::CanConvert(message->raw_obj()));
- Dart_CObject object;
- bool success = ApiObjectConverter::Convert(message->raw_obj(), &object);
- ASSERT(success);
- (*func())(message->dest_port(), &object);
- } else {
- Dart_CObject* object;
- ApiMessageReader reader(message->data(), message->len());
- object = reader.ReadMessage();
- (*func())(message->dest_port(), object);
- }
-
+ Dart_CObject* object;
+ ApiMessageReader reader(message);
+ object = reader.ReadMessage();
+ (*func())(message->dest_port(), object);
delete message;
return kOK;
}
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698