Issue 25238. Update LoclaElement(s) visible ranges during incremental resolution.

Issue 25238. Update LoclaElement(s) visible ranges during incremental resolution.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25238

Committed: https://github.com/dart-lang/sdk/commit/56f0adf9bf527b9b8d69ec296a4387e4ea53264f

[Brian Wilkerson, 2015-12-12 15:31:56]

LGTM

https://codereview.chromium.org/1522583005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/1522583005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:2010: if (element is
FunctionElementImpl) {
I want to make a couple of changes to the element model first, but then we
should add an internal interface that defines the "setVisibleRange" method so
that we don't have to have all these 'is' tests.

[scheglov, 2015-12-13 01:13:06]

On 2015/12/12 15:31:56, Brian Wilkerson wrote:
> LGTM
> 
>
https://codereview.chromium.org/1522583005/diff/1/pkg/analyzer/lib/src/genera...
> File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):
> 
>
https://codereview.chromium.org/1522583005/diff/1/pkg/analyzer/lib/src/genera...
> pkg/analyzer/lib/src/generated/incremental_resolver.dart:2010: if (element is
> FunctionElementImpl) {
> I want to make a couple of changes to the element model first, but then we
> should add an internal interface that defines the "setVisibleRange" method so
> that we don't have to have all these 'is' tests.

Agreed, it would be nice to have.

[scheglov, 2015-12-13 01:15:10]

Description was changed from

==========
Issue 25238. Update LoclaElement(s) visible ranges during incremental
resolution.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25238
==========

to

==========
Issue 25238. Update LoclaElement(s) visible ranges during incremental
resolution.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25238

Committed:
https://github.com/dart-lang/sdk/commit/56f0adf9bf527b9b8d69ec296a4387e4ea53264f
==========

[scheglov, 2015-12-13 01:15:11]

Committed patchset #1 (id:1) manually as
56f0adf9bf527b9b8d69ec296a4387e4ea53264f (presubmit successful).