Issue 25238. Update LoclaElement(s) visible ranges during incremental resolution.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.incremental_resolver_test;
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
@@ skipping 4426 matching lines @@
 foo(int p) {}
 ''');
     // Complete analysis, e.g. compute VERIFY_ERRORS.
     _runTasks();
     // Invalidate VERIFY_ERRORS.
     AnalysisCache cache = analysisContext2.analysisCache;
     LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
     CacheEntry cacheEntry = cache.get(target);
     expect(cacheEntry.getValue(VERIFY_ERRORS), hasLength(2));
     cacheEntry.setState(VERIFY_ERRORS, CacheState.INVALID);
-    // Don't run tasks, so don't recompute VERIFY_ERRORS before incremental.
-    _updateAndValidate(
+    // Perform incremental resolution.
+    _resetWithIncremental(true);
+    analysisContext2.setContents(
+        source,
         r'''
 main() {
   foo(0);
 }
 main2() {
   foo('bbb');
 }
 foo(int p) {}
-''',
-        runTasksBeforeIncremental: false);
-    // Incremental analysis should have left VERIFY_ERRORS invalid,
-    // so it was correctly recomputed later during the full analysis.
+''');
+    // VERIFY_ERRORS is still invalid.
+    expect(cacheEntry.getState(VERIFY_ERRORS), CacheState.INVALID);
+    // Continue analysis - run tasks, so recompute VERIFY_ERRORS.
+    _runTasks();
+    expect(cacheEntry.getState(VERIFY_ERRORS), CacheState.VALID);
     expect(cacheEntry.getValue(VERIFY_ERRORS), hasLength(1));
   }
 
   void test_updateErrors_removeExisting_hint() {
     _resolveUnit(r'''
 int main() {
 }
 ''');
     _updateAndValidate(r'''
 int main() {
@@ skipping 45 matching lines @@
 }
 f2() {
   print(22);
 }
 f3() {
   print(333)
 }
 ''');
   }
 
+  void test_visibleRange() {
+    _resolveUnit(r'''
+class Test {
+  method1(p1) {
+    var v1;
+    f1() {}
+    return 1;
+  }
+  method2(p2) {
+    var v2;
+    f2() {}
+    return 2;
+  }
+  method3(p3) {
+    var v3;
+    f3() {}
+    return 3;
+  }
+}
+''');
+    _updateAndValidate(r'''
+class Test {
+  method1(p1) {
+    var v1;
+    f1() {}
+    return 1;
+  }
+  method2(p2) {
+    var v2;
+    f2() {}
+    return 2222;
+  }
+  method3(p3) {
+    var v3;
+    f3() {}
+    return 3;
+  }
+}
+''');
+  }
+
   void test_whitespace_getElementAt() {
     _resolveUnit(r'''
 class A {}
 class B extends A {}
 ''');
     {
       ClassElement typeA = oldUnitElement.getType('A');
       expect(oldUnitElement.getElementAt(typeA.nameOffset), typeA);
     }
     {
@@ skipping 85 matching lines @@
     expect(analysisContext.getResolvedCompilationUnit(source, oldLibrary),
         same(oldUnit));
     // The only expected pending task should return the same resolved
     // "newUnit", so all clients will get it using the usual way.
     AnalysisResult analysisResult = analysisContext.performAnalysisTask();
     ChangeNotice notice = analysisResult.changeNotices[0];
     expect(notice.resolvedDartUnit, same(newUnit));
     // Resolve "newCode" from scratch.
     if (compareWithFull) {
       _resetWithIncremental(false);
+      changeSource(source, '');
       changeSource(source, newCode);
       _runTasks();
       LibraryElement library = resolve2(source);
       CompilationUnit fullNewUnit = resolveCompilationUnit(source, library);
       // Validate tokens.
       _assertEqualTokens(newUnit, fullNewUnit);
       // Validate LineInfo
       _assertEqualLineInfo(newLineInfo, analysisContext.getLineInfo(source));
       // Validate that "incremental" and "full" units have the same resolution.
       try {
@@ skipping 251 matching lines @@
     return ResolutionContextBuilder.contextFor(node, listener).scope;
   }
 }
 
 class _Edit {
   final int offset;
   final int length;
   final String replacement;
   _Edit(this.offset, this.length, this.replacement);
 }