Modernize autofill popup design

Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in issue 567755.

BUG=567755
Committed: https://crrev.com/48671daec4184675fe6fd61b43a9f8ee0d535ec4
Cr-Commit-Position: refs/heads/master@{#371383}

[gogerald1, 2015-12-11 19:20:10]

Patchset #1 (id:1) has been deleted

[gogerald1, 2015-12-11 21:25:28]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2015-12-11 21:38:02]

Description was changed from

==========
mordernize


mordernize


mordernize

BUG=
==========

to

==========
Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in
issue 567755.

BUG=567755
==========

[gogerald1, 2015-12-11 21:58:28]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2015-12-13 21:34:14]

gogerald@chromium.org changed reviewers:
+ estade@chromium.org

[gogerald1, 2015-12-13 21:34:15]

Hi Evan, please help review this CL.

Ganggui

[Evan Stade, 2015-12-14 21:37:44]

I think this would be a great opportunity to completely overhaul the way this
popup is managed. The controller should not know things like the bounds of a
row. That's the responsibility of the view. The controller should only know
about the backing model and user actions (hover, select, etc.).

FWIW I've always wanted to make this refactor because the current way the code
is structured is so unorthodox but I have never had new mocks in hand to work
from.

https://codereview.chromium.org/1522563002/diff/80001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/autofill_popup_controller_impl.cc (right):

https://codereview.chromium.org/1522563002/diff/80001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:125:
ui::MaterialDesignController::IsModeMaterial()
please don't reuse this flag. I'm not sure we need to develop this behind a flag
at all, but if you do want to, add a new flag (because if we decide to flip the
default value of this flag for some platform, we won't be considering whether
the Autofill popup is ready).

https://codereview.chromium.org/1522563002/diff/80001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/autofill_popup_controller_impl.cc:575: if (identifier
== POPUP_ITEM_ID_AUTOFILL_OPTIONS)
ternary operator

[gogerald1, 2016-01-25 15:09:20]

Hey Evan, Rebased this CL since Matheiu has refactored the code, PTAL.

[Evan Stade, 2016-01-25 23:19:38]

lgtm

https://codereview.chromium.org/1522563002/diff/100001/chrome/browser/ui/auto...
File chrome/browser/ui/autofill/autofill_popup_layout_model.cc (right):

https://codereview.chromium.org/1522563002/diff/100001/chrome/browser/ui/auto...
chrome/browser/ui/autofill/autofill_popup_layout_model.cc:25: const size_t
kRowHeight = 44;
I would recommend reusing MenuConfig layout constants such as item_bottom_margin
instead of hardcoding some value which will match at most one platform

[gogerald1, 2016-01-25 23:43:18]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-01-25 23:43:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522563002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522563002/100001

[commit-bot: I haz the power, 2016-01-26 00:42:59]

Description was changed from

==========
Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in
issue 567755.

BUG=567755
==========

to

==========
Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in
issue 567755.

BUG=567755
==========

[commit-bot: I haz the power, 2016-01-26 00:43:00]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-01-26 00:44:14]

Description was changed from

==========
Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in
issue 567755.

BUG=567755
==========

to

==========
Modernize autofill popup design.

This CL is part of the work to mordernize autofill popup design as mentioned in
issue 567755.

BUG=567755

Committed: https://crrev.com/48671daec4184675fe6fd61b43a9f8ee0d535ec4
Cr-Commit-Position: refs/heads/master@{#371383}
==========

[commit-bot: I haz the power, 2016-01-26 00:44:14]

Patchset 3 (id:??) landed as
https://crrev.com/48671daec4184675fe6fd61b43a9f8ee0d535ec4
Cr-Commit-Position: refs/heads/master@{#371383}