components/autofill/core/browser/autofill_external_delegate.cc - Issue 1522563002: Modernize autofill popup design

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 1522563002: Modernize autofill popup design (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index 25ff5850856a4911b40aa3e6e436c719ee79a073..6a7566f8c64c305c9c80c9282bb8ed25d5da28a0 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -303,6 +303,8 @@ void AutofillExternalDelegate::ApplyAutofillOptions(

suggestions->push_back(Suggestion(l10n_util::GetStringUTF16(

IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION

: IDS_AUTOFILL_OPTIONS_POPUP)));

+ suggestions->back().label =

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS_POPUP_LABEL);

suggestions->back().frontend_id = POPUP_ITEM_ID_AUTOFILL_OPTIONS;

if (IsKeyboardAccessoryEnabled())

suggestions->back().icon = base::ASCIIToUTF16("settings");