Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1522443004: Listen for DidStopLoading in NavigateIframeToURL. (Closed)

Created:
5 years ago by Charlie Reis
Modified:
5 years ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, lfg, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Listen for DidStopLoading in NavigateIframeToURL. This wasn't possible before, but we now wait to generate the DidStopLoading until all frames (including out-of-process iframes) finish loading. BUG=436250 TEST=Existing tests still pass. Committed: https://crrev.com/748a2c971a1112184aa4a13ad32d7141f95306da Cr-Commit-Position: refs/heads/master@{#365287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M content/public/test/browser_test_utils.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Reis
This seems to be passing the try jobs. Shall we give it a try on ...
5 years ago (2015-12-12 00:12:05 UTC) #2
nasko
LGTM
5 years ago (2015-12-14 21:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522443004/1
5 years ago (2015-12-15 17:23:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 18:09:41 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 18:10:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/748a2c971a1112184aa4a13ad32d7141f95306da
Cr-Commit-Position: refs/heads/master@{#365287}

Powered by Google App Engine
This is Rietveld 408576698